From e3a8d38e19eb09fa48c6c76901ad235b4265273e Mon Sep 17 00:00:00 2001
From: Josh Cardenzana <jcardenzana@irap.omp.eu>
Date: Thu, 8 Nov 2018 09:15:20 +0100
Subject: [PATCH] Add requirement for minimum number of events in a time bin for background consideration (#2713)

---
 src/ctfindvar/ctfindvar.cpp | 17 ++++++++++++++---
 src/ctfindvar/ctfindvar.hpp |  1 +
 2 files changed, 15 insertions(+), 3 deletions(-)

diff --git a/src/ctfindvar/ctfindvar.cpp b/src/ctfindvar/ctfindvar.cpp
index 4c16d22..72fb7d3 100644
--- a/src/ctfindvar/ctfindvar.cpp
+++ b/src/ctfindvar/ctfindvar.cpp
@@ -421,11 +421,19 @@ void ctfindvar::get_variability_sig(const int& pix_number,
         for (int i=0; i< nbins; i++) //looping over all the GTIs of the pixel
         {
            alpha=0;
-           if (accepted_bin_bckg_vector[i]==0) continue;     //the GTI is discared from bckg calculation and not checked again.
+           //the GTI is discared from bckg calculation and not checked again.
+           if (accepted_bin_bckg_vector[i]==0) {
+               continue;
+           } 
+           // Check if bin fails minoff check
+           else if (m_counts(pix_number, i) < m_minoff) {
+               accepted_bin_bckg_vector[i]=0;
+               continue;
+           }
            int background_count=0;
            for (int j=0;j<nbins;j++)  // for one GTI selected (i), looping over all the others (j).
            {
-                if (j!=i &&accepted_bin_bckg_vector[j]==1)
+                if (j!=i && accepted_bin_bckg_vector[j]==1)
                 {
                     background_count+= m_counts(pix_number, j);
                     alpha++;
@@ -436,7 +444,7 @@ void ctfindvar::get_variability_sig(const int& pix_number,
            non = m_counts(pix_number, i); 
            noff = background_bin_array[i];
            alpha = (1./alpha);
-          
+
            ///////////////////////////////////////////////////////////////////////////////// 
            // Compute sensitivity in Gaussian sigma
            double alpha1 = alpha + 1.0;
@@ -643,6 +651,9 @@ void ctfindvar::get_parameters(void)
     m_emin = GEnergy((*this)["emin"].real(), "TeV");
     m_emax = GEnergy((*this)["emax"].real(), "TeV");
 
+    // Get minimum counts for a bin to be considered in Noff calculation
+    m_minoff = (*this)["minoff"].real();
+
     // Write parameters into logger
     log_parameters(TERSE);
 
diff --git a/src/ctfindvar/ctfindvar.hpp b/src/ctfindvar/ctfindvar.hpp
index f979f6f..512da2f 100644
--- a/src/ctfindvar/ctfindvar.hpp
+++ b/src/ctfindvar/ctfindvar.hpp
@@ -89,6 +89,7 @@ protected:
     GSkyMap  m_counts;                 //!< Counts for each time interval
     GGti     m_gti;                    //!< List of time intervals
     GModels  m_inmodel;                //!< List of models for source positions
+    double   m_minoff;                 //!< Minimum counts for use in significance calculation
     GSkyMap  m_peaksigmap;             //!< Skymap holding the maximum significance
     GNdarray m_pixsigsrc;              //!< Store distributions of the source significances
     GNdarray m_pixsigmax;              //!< Store distribution for pixel with max significance
--
libgit2 0.21.4