From 3647c518d2885c9ab022d68340a659818ceab8ac Mon Sep 17 00:00:00 2001
From: Jürgen Knödlseder <jurgen.knodlseder@irap.omp.eu>
Date: Thu, 19 Feb 2015 16:11:22 +0100
Subject: [PATCH] Correct flux computation (was still based on the old interface and now leads to excessive memory usage). This fixes bug #1425.

---
 scripts/cssens.py | 28 +++++++++++++++-------------
 1 file changed, 15 insertions(+), 13 deletions(-)

diff --git a/scripts/cssens.py b/scripts/cssens.py
index 6798198..16b927d 100755
--- a/scripts/cssens.py
+++ b/scripts/cssens.py
@@ -154,7 +154,7 @@ class cssens(GApplication):
 
         # Set some fixed parameters
         self.m_log   = False # Logging in client tools
-        self.m_debug = False # Debugging in client tools
+        self.m_debug = False # self["debug"].boolean() # Debugging in client tools
         
         # Return
         return
@@ -424,26 +424,28 @@ class cssens(GApplication):
         diffSens_value = []
         iter           = 0
         test_flux      = 0.1  # This is the initial test flux in Crab units
-        
+
         # Loop until we break
         while True:
-        
+
             # Update iteration counter
             iter += 1
-            
+
             # Write header
             if self.logExplicit():
                 self.log.header2("Iteration "+str(iter))
 
             # Set test flux
-            full_model["Test"]['Prefactor'].value(test_flux)
-            obs.models(full_model)
-            
+            src_model = full_model.copy()
+            crab_flux = src_model["Test"]['Prefactor'].value()
+            src_model["Test"]['Prefactor'].value(crab_flux*test_flux)
+            obs.models(src_model)
+
             # Simulate events
             sim = obsutils.sim(obs, nbins=self.m_nbins, seed=iter, \
                                binsz=self.m_binsz, npix=self.m_npix, \
                                log=self.m_log, debug=self.m_debug)
-        
+
             # Determine number of events in simulation
             nevents = 0.0
             for run in sim:
@@ -462,7 +464,7 @@ class cssens(GApplication):
             result_bgm = like.obs().models().copy()
             LogL_bgm   = like.opt().value()
             npred_bgm  = like.obs().npred()
-            
+
             # Assess quality based on a comparison between Npred and Nevents
             quality_bgm = npred_bgm-nevents
 
@@ -484,7 +486,7 @@ class cssens(GApplication):
                 if self.logExplicit():
                     self.log("Fit quality outside required range. Start over.\n")
                 continue
-            
+
             # Write model fit results
             if self.logExplicit():
                 for model in result_bgm:
@@ -495,7 +497,7 @@ class cssens(GApplication):
                         self.log(str(par)+"\n")
             
             # Fit background and test source
-            sim.models(full_model)
+            sim.models(src_model)
             like       = obsutils.fit(sim, log=self.m_log, debug=self.m_debug)
             result_all = like.obs().models().copy()
             LogL_all   = like.opt().value()
@@ -541,8 +543,8 @@ class cssens(GApplication):
                 continue
 
             # Get fitted Crab, photon and energy fluxes
-            cflux     = result_all["Test"]['Prefactor'].value()
-            cflux_err = result_all["Test"]['Prefactor'].error()
+            cflux     = result_all["Test"]['Prefactor'].value() / crab_flux
+            cflux_err = result_all["Test"]['Prefactor'].error() / crab_flux
             pflux     = result_all["Test"].spectral().flux(emin, emax)
             eflux     = result_all["Test"].spectral().eflux(emin, emax)
 
--
libgit2 0.21.4