From e970422268fcafa04f277fe12c9bf16da5976420 Mon Sep 17 00:00:00 2001 From: Jürgen Knödlseder Date: Mon, 22 Jan 2018 11:32:35 +0100 Subject: [PATCH] Change DATE_OBS, DATE_END, TIME_OBS and TIME_END FITS keywords into DATA-OBS, DATE-END, TIME-OBS and TIME-END --- ChangeLog | 4 +++- NEWS | 5 ++++- doc/source/admin/release_history/1.5.rst | 2 ++ inst/cta/src/GCTACubeExposure.cpp | 8 ++++---- inst/cta/src/GCTAObservation.cpp | 8 ++++---- 5 files changed, 17 insertions(+), 10 deletions(-) diff --git a/ChangeLog b/ChangeLog index 6541bce..baf2356 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,8 +1,10 @@ -2018-01-16 +2018-01-22 * Version 1.5.0 released ========================= + Change DATE_OBS, DATE_END, TIME_OBS and TIME_END FITS keywords into DATA-OBS, + DATE-END, TIME-OBS and TIME-END Non-point source model throws exception in On/Off fitting (#2296) Set reference time to CTA reference time in GCTAEventcube, GCTAEventList and GCTACubeExposure (#2295) diff --git a/NEWS b/NEWS index 1b1d80f..dc940ae 100644 --- a/NEWS +++ b/NEWS @@ -1,6 +1,6 @@ New Features and Important Changes in GammaLib 1.5.0 -16 January 2018 +22 January 2018 1. Introduction @@ -252,6 +252,9 @@ also position fitting is now possible for Fermi-LAT (#604, #2183). 20. CTA interface ----------------- +Change DATE_OBS, DATE_END, TIME_OBS and TIME_END FITS keywords into DATA-OBS, +DATE-END, TIME-OBS and TIME-END. + If a non-point source model is fitted in an On/Off fitting an exception is thrown, since On/Off fitting so far only is correct for point source models (#2296). diff --git a/doc/source/admin/release_history/1.5.rst b/doc/source/admin/release_history/1.5.rst index 6aedb5c..cde4fb5 100644 --- a/doc/source/admin/release_history/1.5.rst +++ b/doc/source/admin/release_history/1.5.rst @@ -19,6 +19,8 @@ In particular, this release provides: Bug fixes --------- +* Change ``DATE_OBS``, ``DATE_END``, ``TIME_OBS`` and ``TIME_END`` FITS keywords + into ``DATA-OBS``, ``DATE-END``, ``TIME-OBS`` and ``TIME-END`` * [`2234 `_] - Prevent negative response values for COMPTEL IRF * [`2184 `_] - diff --git a/inst/cta/src/GCTACubeExposure.cpp b/inst/cta/src/GCTACubeExposure.cpp index dda4364..b82e9b7 100644 --- a/inst/cta/src/GCTACubeExposure.cpp +++ b/inst/cta/src/GCTACubeExposure.cpp @@ -857,10 +857,10 @@ void GCTACubeExposure::write_attributes(GFitsHDU& hdu) const hdu.card("CREATOR", "GammaLib", "Program which created the file"); hdu.card("TELESCOP", "unknown", "Telescope"); hdu.card("OBS_ID", "unknown", "Observation identifier"); - hdu.card("DATE_OBS", date_obs, "Observation start date"); - hdu.card("TIME_OBS", time_obs, "Observation start time"); - hdu.card("DATE_END", date_end, "Observation end date"); - hdu.card("TIME_END", time_end, "Observation end time"); + hdu.card("DATE-OBS", date_obs, "Observation start date"); + hdu.card("TIME-OBS", time_obs, "Observation start time"); + hdu.card("DATE-END", date_end, "Observation end date"); + hdu.card("TIME-END", time_end, "Observation end time"); // Set observation time information hdu.card("TSTART", tstart, "[s] Mission time of start of observation"); diff --git a/inst/cta/src/GCTAObservation.cpp b/inst/cta/src/GCTAObservation.cpp index ced96bc..bc4b5c6 100644 --- a/inst/cta/src/GCTAObservation.cpp +++ b/inst/cta/src/GCTAObservation.cpp @@ -1699,10 +1699,10 @@ void GCTAObservation::write_attributes(GFitsHDU& hdu) const hdu.card("CREATOR", "GammaLib", "Program which created the file"); hdu.card("TELESCOP", instrument(), "Telescope"); hdu.card("OBS_ID", obs_id(), "Observation identifier"); - hdu.card("DATE_OBS", date_obs, "Observation start date"); - hdu.card("TIME_OBS", time_obs, "Observation start time"); - hdu.card("DATE_END", date_end, "Observation end date"); - hdu.card("TIME_END", time_end, "Observation end time"); + hdu.card("DATE-OBS", date_obs, "Observation start date"); + hdu.card("TIME-OBS", time_obs, "Observation start time"); + hdu.card("DATE-END", date_end, "Observation end date"); + hdu.card("TIME-END", time_end, "Observation end time"); // Set observation time information hdu.card("TSTART", tstart, "[s] Mission time of start of observation"); -- libgit2 0.21.4