Alexander Ziegler / gammalib

A weighting sky map has been added to the CTA event cube that allows to correctly take into account data space selections. This is in particular needed for stacking event lists with different energy thresholds in an event cube, but can also be used for combining event lists with different ROIs.

Removed size() method.

Renamed filename() method to url().
Renamed fullname() method to operator().

…is allows to use a dummy map.

Only the protected interface has been affected by the review. Now all FITS arguments are passed by reference.

All methods returning a solid angle are now named solidangle().

GEvents
GEventList
  The clobber argument of the save() method is now passed as const
  reference.

GEventCube
  The clobber argument of the save() method and the axis argument of the
  naxis() method are now passed as const references.

GTime
  The secs() method now returns a const reference.

GTimeReference
  The load constructor and the read() and write() methods take
  a const reference instead of a pointer.

GGti
  The read() and write() methods now use references instead of
  pointers. The clobber argument in the save() method is passed
  as const reference.

GEbounds
  The read() and write() methods now use FITS references instead
  of pointers. The clobber argument in the save() method is passed
  as const reference.

GPhoton
  Add mcid argument to Photon constructor (defaults to -1).

The GFits class now derives from GContainer and implements all generic container class methods (at(), size(), isempty(), set(), append(), insert(), remove(), reserve(), extend()). The hashdu() method has been renamed to contains() for compliance with other container classes. The hdu() methods have been renamed to at(), also for compliance. Boolean arguments are now passed as const references, and members are returned as const references. HDU access operators[] have been implemented to access FITS extensions without range checking.

When using the Hammer-Aitoff projection, the pixel-to-spherical used in GCTAEventCube::set_directions may fell as pixels may correspond to zones that do not represent sky regions. To prevent this problem, any exception is catched and the solid angle of the pixel is set to 0. This has the nice side effect of filtering out the bin during model fitting as the solid angle is used to multiply the model value.

The GSkyPixel class now handles 1D and 2D sky indices. This made the distinctive 1D and 2D methods in GSkyProjection and the derived classes obsolete. Now, all projection classes take GSkyPixel as argument.

The GSkymap class now uses the universal GSkyPixel class. Methods have been renamed consistently. An integer index is now consistently called "sky map index" and the GSkyPixel object is named a "sky map pixel". Methods operating on indices contain now "inx", method operating on sky map pixels "pix".

Add GChatter argument to print() method.

The print() method now takes an argument of type GChatter to control the chattiness of the output in a homogenous manner.
Pass NORMAL chatter level in __str__ method.
Add chatter argument to print() methods.
Use GLog::chatter() method to control the chattiness of the log stream operator.
Add chatter() methods and provide member access through const references.
Add chatter() methods, provide member access through const references, and declare one liners as inline methods.

The chatter() methods control the new m_chatter attribute that is used to control the chattiness of the object's print() methods.
name() and version() methods return const references.
logFileOpen() method now sets the chattiness from the applications's chatter parameter, and name() and version() methods now return a const reference.

The GTime interface has been reworked, and some adaption was needed. One of the main changes was the replacement of the met() method by the secs() method. The secs() method returns now the time in seconds in the native GammaLib time reference.

Conflicts:
	configure.ac
	src/Makefile.am
	test/Makefile.am

The naxis method previously returned the number of sky pixels for the 3rd axis instead of returning the number of energy bins. This has been corrected. Now the number of energy bins is returned in naxis is called with an argument of 2.

…tence of internal arrays in pointer() method