-
…ients argument (#1847) The eval_gradients() methods duplicate much of the code of the eval() methods. To increase the maintainability of the code, the eval_gradients() methods have been removed, and the computation of partial derivatives is now done by the eval() methods if the optional gradients argument is set to true.
-
Having only 4 integration iterations leads to an exception as the default order for integration is 5. Hence the number of integration iterations was switched to 5 to prevent this problem. Solves #1472.
-
…c_cast statements by static_cast.
-
Earlier gcc compilers do not allow creation of an instance in the return statement.
-
Minor adjustments were needed to make the code compile.
-
The energy integration has been implemented in the GModelSky::integrate_energy method. For that purpose, the GModelSky::edisp_kern class has been added to GModelSky that provides the kernel for the integration. The GResponse::src_ebounds method has been added to determine the true energy boundaries for a given observed event energy. The method is virtual in GResponse and always throws a "feature not implemented" exception. The method has then also been implemented in GCTAResponse to provide the true energy boundaries.
-
The coding and design conventions (CDC) document was also updated.
-
The GFunction::eval interface has been revised and all affected GammaLib classes have been adapted.
-
The old scheme with the deadtime correction in the base class led to some irf/npred methods having deadtime correction and others without correction. This definitely was a source of confusion and potential errors. Now, deadtime corrections have to be done at the instrument level, enhancing clarity of the interfaces and flexibility, at the expense of some burden on the instrument specific response class implementation that now has to take care of the proper handling of deadtime.
-
Renamed irf_extended to ird_radial and npred_extended to npred_radial. Renamed also the radial kernel integration methods to npred_radial_kern_theta and npred_radial_kern_phi. Handle properly different spatial model components: point source, radial source, elliptical source, diffuse source.
-
The ostream and GLog functions are now implement on the GBase level.
