Matteo Balbo / gammalib

The coding and design conventions (CDC) document was also updated.

All methods returning a solid angle are now named solidangle().

The GFits class now derives from GContainer and implements all generic container class methods (at(), size(), isempty(), set(), append(), insert(), remove(), reserve(), extend()). The hashdu() method has been renamed to contains() for compliance with other container classes. The hdu() methods have been renamed to at(), also for compliance. Boolean arguments are now passed as const references, and members are returned as const references. HDU access operators[] have been implemented to access FITS extensions without range checking.

The GSkyPixel class now handles 1D and 2D sky indices. This made the distinctive 1D and 2D methods in GSkyProjection and the derived classes obsolete. Now, all projection classes take GSkyPixel as argument.

The GSkymap class now uses the universal GSkyPixel class. Methods have been renamed consistently. An integer index is now consistently called "sky map index" and the GSkyPixel object is named a "sky map pixel". Methods operating on indices contain now "inx", method operating on sky map pixels "pix".

The GWcslib class has been renamed to GWcs for consistency with the naming convention for GammaLib base classes. All WCS implementations derive now from GWcs. The code has been adapted to this new naming convention.

The Healpix pixelisation is not a World Coordinate System projection, and to make this clear the name has been changed from GWcsHPX to GHealpix. The code has been adapted to this new naming convention.

After renaming GWcs to GSkyProjection the code has been adapted to the new naming convention.

A major revision of the GFitsTable class interface has been done, making it more similar to the interface of other container classes. In particular, the column access operator now returns a pointer instead of a reference, preventing code slicing. The set() method has been introduced to set columns in a table. The append_column() and insert_column() methods have been renamed to append() and insert() as they act on columns, and a table is a column container. Some arguments or return values are now also declared as const references. A size() method has been added that return the number of table columns.

As the GFitsTable class is widely used throughout GammaLib, a number of classes had to be adapted to this new interface.

Add GChatter argument to print() method.

The print() method now takes an argument of type GChatter to control the chattiness of the output in a homogenous manner.
Pass NORMAL chatter level in __str__ method.
Add chatter argument to print() methods.
Use GLog::chatter() method to control the chattiness of the log stream operator.
Add chatter() methods and provide member access through const references.
Add chatter() methods, provide member access through const references, and declare one liners as inline methods.

The chatter() methods control the new m_chatter attribute that is used to control the chattiness of the object's print() methods.
name() and version() methods return const references.
logFileOpen() method now sets the chattiness from the applications's chatter parameter, and name() and version() methods now return a const reference.

The ostream and GLog functions are now implement on the GBase level.

A sky direction access operator has been added that provides intensity values by performing a bi-linear interpolation between the skymap pixels. The operator takes a GSkyDir object as argument. If the sky direction falls outside the skymap, and intensity of 0 is returned. The bi-linear interpolation has been tested using the test_model_spatial_map.py script in the test folder.

Furthermore, two methods have been added that check whether a ski pixel (class GSkyPixel) or a sky direction (class GSkyDir) falls within the skymap.

Finally, all GSkyDir  arguments have been declared as const GSkyDir&, and also the map indices are now passed by reference in the operators.

The methods xy2pix and pix2xy were moved from the private domain to the public domain.

… only useful for phi-independent LAT livetime cubes)