Specifying logfile= does not create a log file.

Log file creation may now be disabled by specifying logfile= on the command line. The GPars class has to be changed for this to support empty value arguments.

Specifying logfile= does not create a log file.
Log file creation may now be disabled by specifying logfile= on the command line. The GPars class has to be changed for this to support empty value arguments.
Jürgen Knödlseder
1 parent ff9009be
Showing 2 changed files with 12 additions and 9 deletions
src/app/GApplication.cpp
src/app/GPars.cpp
@@ -281,15 +281,22 @@ double GApplication::celapse(void) const
 /***********************************************************************//**
  * @brief Open log file
  *
- * @param[in] clobber (defaults to true)
+ * @param[in] clobber Overwrite (true) or append (false) to existing file
+ *                    (defaults to true)
  *
  * Opens application log file and sets the logger chattiness dependent on
  * the chatter parameter of the application.
  ***************************************************************************/
 void GApplication::logFileOpen(const bool& clobber)
 {
-    // Initialise the application logger
-    log.open(log_filename(), clobber);
+    // Open logger only if filename is non-empty
+    if (!log_filename().empty()) {
+
+        // Initialise the application logger
+        log.open(log_filename(), clobber);
+
+
+    }
  
     // Set logger chattiness
     set_log_chatter();
@@ -683,7 +683,7 @@ void GPars::load(const std::string&amp; filename,
     // Overwrite parameter values that are specified in the command line
     for (int i = 1; i < args.size(); ++i) {
  
-        // Extract parameter name and value
+        // Extract parameter name and value (empty values are permitted)
         size_t pos = args[i].find("=");
         if (pos == std::string::npos) {
             throw GException::bad_cmdline_argument(G_LOAD2, args[i],
@@ -695,11 +695,7 @@ void GPars::load(const std::string&amp; filename,
             throw GException::bad_cmdline_argument(G_LOAD2, args[i],
                                        "no parameter name before \"=\"");
         }
-        if (value.length() < 1) {
-            throw GException::bad_cmdline_argument(G_LOAD2, args[i],
-                                       "no parameter value after \"=\"");
-        }
-
+        
         // Check if parameter exists
         if (!contains(name)) {
             throw GException::bad_cmdline_argument(G_LOAD2, args[i],