Avoid illegal memory access in GLog::append().

On Mac OS X I encountered some KERN_INVALID_ADDRESS problems in the GLog::append() method. A possible reason to this was the test of the value of m_buffer[m_buffer.size()-1] without checking whether m_buffer.size() was positive. I added the test, hopefully the KERN_INVALID_ADDRESS problem (which was spurious) goes away.

Avoid illegal memory access in GLog::append().
On Mac OS X I encountered some KERN_INVALID_ADDRESS problems in the GLog::append() method. A possible reason to this was the test of the value of m_buffer[m_buffer.size()-1] without checking whether m_buffer.size() was positive. I added the test, hopefully the KERN_INVALID_ADDRESS problem (which was spurious) goes away.
Jürgen Knödlseder
1 parent a9e1073e
Showing 1 changed file with 3 additions and 3 deletions
src/app/GLog.cpp
@@ -777,10 +777,10 @@ std::string GLog::prefix(void) const
 void GLog::append(std::string arg)
 {
     // If the buffer is empty and at the beginning of a line or if the last
-    // charater is a \n, prepend a prefix at the beginning of the string to
-    // be inserted.
+    // character is a \n then prepend a prefix at the beginning of the string
+    // to be inserted.
     if ((m_buffer.size() == 0 && m_linestart) ||
-        m_buffer[m_buffer.size()-1] == '\n') {
+        (m_buffer.size() > 0 && m_buffer[m_buffer.size()-1] == '\n')) {
  
         // Prepend prefix
         arg.insert(0, prefix());