Johan Bregeon / gammalib

… (blocking has been recognized using the ctobssim unit test).

The map cube is now only loaded when its values should be accessed.

The coding and design conventions (CDC) document was also updated.

All methods returning a solid angle are now named solidangle().

The GSkyPixel class now handles 1D and 2D sky indices. This made the distinctive 1D and 2D methods in GSkyProjection and the derived classes obsolete. Now, all projection classes take GSkyPixel as argument.

The GSkymap class now uses the universal GSkyPixel class. Methods have been renamed consistently. An integer index is now consistently called "sky map index" and the GSkyPixel object is named a "sky map pixel". Methods operating on indices contain now "inx", method operating on sky map pixels "pix".

A consistent radius should be used for MC cache setup and flux computation, otherwise there is a risk that the simulated data differ from the model in overall normalisation.

A contains() method has been added to GCTARoi that checks whether an event in contained within the ROI. This method will become pure virtual in the GRoi class later so that the check can be done independently of the ROI specifications.

The contains() method is now used in GCTAModelBackground for checking whether an event lies within the ROI.

The GCTAInstDir class now only has the dir() method to access and modify the GSkyDir member. All methods that were basically copied from GSkyDir have now been removed to avoid code duplication. Using the dir() method, all methods are now directly accessible from the GSkyDir object.

…ky directions returned by mc() to all pixels that touch a circular region. In addition, only pixels of which the centre falls within the circular region are considered for determining the spectral node function.

Note that this method affects the Monte Carlo cache.

The map cube is no longer normalised, but the values are taken as given. It is assumed that the map cube pixels are given in units of ph/cm2/s/sr/MeV.

The eval() and eval_gradients() methods now provide interpolation of the maps in energy. For this purpose, the energy values of the maps are stored in log10(energy) in the m_logE member node array.

The mc() method has now also been implemented. It takes the nearest map from the map cube and returns a random sky direction following the intensity distribution of this map.

A spectrum() method has been implemented that returns the spatially integrated intensity of each map in the map cube as a GModelSpectralNodes object. This method is used in GModelSky for Monte Carlo simulations.

Add GChatter argument to print() method.

The print() method now takes an argument of type GChatter to control the chattiness of the output in a homogenous manner.
Pass NORMAL chatter level in __str__ method.
Add chatter argument to print() methods.
Use GLog::chatter() method to control the chattiness of the log stream operator.
Add chatter() methods and provide member access through const references.
Add chatter() methods, provide member access through const references, and declare one liners as inline methods.

The chatter() methods control the new m_chatter attribute that is used to control the chattiness of the object's print() methods.
name() and version() methods return const references.
logFileOpen() method now sets the chattiness from the applications's chatter parameter, and name() and version() methods now return a const reference.

The eval() and eval_gradients() methods now take a GPhoton object as argument to allow the implementation of energy and time dependent source morphologies.

GEnergy and GTime objects have been added to the mc() method interface to support equally the implementation of energy and time dependent source morphologies.

So far, no class really implements energy and time dependent source morphologies, but now we have the infrastructure to do so.

The GModelPar interface has been revisited and the code has been adapted to satisfy the new interface.

All diffuse spatial models are now derived from GModelSpatialDiffuse and named GModelSpatialDiffuseXXX.