Eirik Hatlen / gammalib

…ead of row-wise access (#3501)

Renamed the GSkyRegionRect::get_corner() method to GSkyRegionRect::corner() and make local coordinate methods provide. Use GSkyPixel to carry local coordinates in units of radians. Extent the GSkyRegionRect::contains() and GSkyRegionRect::overlaps() method to cover all other possible sky region types.

Adjust GSkyRegionCircle and GSkyRegionMap to the new interface and make sure that their contains() and overlaps() method deal with all other regions.

Adjust the GSkyRegionRect unit test accordingly.

…_logic() methods. (Following circle region implementation, extended). Extended test_GSkyRegions_io() and test_GSkyRegionMap_logic() methods. Obviously lots of tabs have been automatically replaced by spaces.

…se dist/posang). In terms of that, sorted out previous issues towards the poles. No longer need precomputed sin/cos, hence removed cache. Added 1e-10 tolerance for skydir containment check. Changed corners indexing, now starting with +RA+DEC and counting CCW. Improved documentation.

…ect centre and their cartesian representation (previous implementation used difference in RA/DEC)

…rs (method GSkyRegionCircle::contains(GSkyRegion))

…ng now use of the new PA.

…lemented a cludge for computing the overlap of rectangle-rectangle.

…ethod contains_local(GSkyDir). Implemented contains(GSkyRegion) for rectangle.

… (ds9 line) and written to ds9 string. Can be set via radians and degrees, the latter is implemented for the constructor. Changed solid angle computation algorithm.