Gonzalo Rodriguez Fernandez / gammalib

… "xml_has_par" function and made reading of information in observation definition file optional (so that for example energies or ROI can be missing).

When energy boundaries are read from a FITS file, the energy units are set according to the FITS header keyword. If no keyword is provided, units are set to keV.

Upon writing, the energy units can be specified as an argument.

The coding and design conventions (CDC) document was also updated.

GTime
  The secs() method now returns a const reference.

GTimeReference
  The load constructor and the read() and write() methods take
  a const reference instead of a pointer.

GGti
  The read() and write() methods now use references instead of
  pointers. The clobber argument in the save() method is passed
  as const reference.

GEbounds
  The read() and write() methods now use FITS references instead
  of pointers. The clobber argument in the save() method is passed
  as const reference.

GPhoton
  Add mcid argument to Photon constructor (defaults to -1).

A major revision of the GFitsTable class interface has been done, making it more similar to the interface of other container classes. In particular, the column access operator now returns a pointer instead of a reference, preventing code slicing. The set() method has been introduced to set columns in a table. The append_column() and insert_column() methods have been renamed to append() and insert() as they act on columns, and a table is a column container. Some arguments or return values are now also declared as const references. A size() method has been added that return the number of table columns.

As the GFitsTable class is widely used throughout GammaLib, a number of classes had to be adapted to this new interface.

The ewidth() method returns the bin width of an energy bin.

The energy bin is now defines as min <= energy < max, hence the maximum bin energy is not included in the bin.

Add GChatter argument to print() method.

The print() method now takes an argument of type GChatter to control the chattiness of the output in a homogenous manner.
Pass NORMAL chatter level in __str__ method.
Add chatter argument to print() methods.
Use GLog::chatter() method to control the chattiness of the log stream operator.
Add chatter() methods and provide member access through const references.
Add chatter() methods, provide member access through const references, and declare one liners as inline methods.

The chatter() methods control the new m_chatter attribute that is used to control the chattiness of the object's print() methods.
name() and version() methods return const references.
logFileOpen() method now sets the chattiness from the applications's chatter parameter, and name() and version() methods now return a const reference.

The container class method name pop() was changed to remove() to be complatible with the Python syntax for lists.

The add() method has been renamed to merge() to make clear that this method performs a merging of intervals.

The Doxygen documentation has been improved, syntax errors have been corrected, and the language usage is more concise.

The add method inserts energy intervals by merging with any existing intervals.

The extend method allows to append energy boundaries to the object.

GEbounds now derives from GContainer and implements all required methods. In addition, an energy interval constructor has been added that allows one line construction of logarithmically or linearly spaced energy boundaries.

Public interface changes:
- setlin, setlog: put the number argument first
- emin, emax, emean, elogmean: pass index by reference

From the semantics, the isin() method name was wrong (as one would write ebounds.isin(energy)). Renaming the method to contains() corrects the semantics (ebounds.contains(energy)).

The ostream and GLog functions are not defined at the GBase level.