Commit 39311c09ccfd4c3652d08638b69ee424e7d831dd
1 parent
906ea8c2
Increase number of integration iterations from 4 to 5.
Having only 4 integration iterations leads to an exception as the default order for integration is 5. Hence the number of integration iterations was switched to 5 to prevent this problem. Solves #1472.
Showing
4 changed files
with
11 additions
and
4 deletions
ChangeLog
| 1 | -2015-06-05 Juergen Knoedlseder <jurgen.knodlseder@irap.omp.eu> | |
| 1 | +2015-06-06 Juergen Knoedlseder <jurgen.knodlseder@irap.omp.eu> | |
| 2 | 2 | |
| 3 | 3 | * Version 0.11.0 released |
| 4 | 4 | ========================= |
| 5 | 5 | |
| 6 | 6 | Correct model gradient computation |
| 7 | + Increased number of integration iterations for energy dispersion (#1472) | |
| 7 | 8 | Add GOptimizerLM::logger() method, logger constructor takes pointer (#1471) |
| 8 | 9 | Replaced fixed precision integration by fixed iterations (#1466) |
| 9 | 10 | Implement rejection method for skymap Monte Carlo (#1465) | ... | ... |
NEWS
| ... | ... | @@ -2,7 +2,7 @@ New Features and Important Changes in GammaLib 0.11.0 |
| 2 | 2 | |
| 3 | 3 | Author(s) : Juergen Knoedlseder |
| 4 | 4 | |
| 5 | -5 June 2015 | |
| 5 | +6 June 2015 | |
| 6 | 6 | |
| 7 | 7 | |
| 8 | 8 | 1. Introduction |
| ... | ... | @@ -66,6 +66,9 @@ Integration in npred() is now done using a fixed number of Romberg iterations |
| 66 | 66 | instead of using the integration precision. This will assure that the log- |
| 67 | 67 | likelihood function is smooth. |
| 68 | 68 | |
| 69 | +The number of integration iterations for the energy dispersion was changed from | |
| 70 | +4 to 5 to make it compatible with the default integration order. | |
| 71 | + | |
| 69 | 72 | |
| 70 | 73 | 11. Optimization module |
| 71 | 74 | ----------------------- |
| ... | ... | @@ -125,6 +128,9 @@ All integrations are now done using a fixed number of Romberg iterations |
| 125 | 128 | instead of using the integration precision. This will assure that the log- |
| 126 | 129 | likelihood function is smooth. |
| 127 | 130 | |
| 131 | +The number of integration iterations for the energy dispersion was changed from | |
| 132 | +4 to 5 to make it compatible with the default integration order. | |
| 133 | + | |
| 128 | 134 | |
| 129 | 135 | 21. COMPTEL interface |
| 130 | 136 | --------------------- | ... | ... |
inst/cta/src/GCTAResponseIrf.cpp
| ... | ... | @@ -471,7 +471,7 @@ double GCTAResponseIrf::nroi(const GModelSky& model, |
| 471 | 471 | const GObservation& obs) const |
| 472 | 472 | { |
| 473 | 473 | // Set number of iterations for Romberg integration. |
| 474 | - static const int iter = 4; | |
| 474 | + static const int iter = 5; | |
| 475 | 475 | |
| 476 | 476 | // Initialise Nroi value |
| 477 | 477 | double nroi = 0.0; | ... | ... |
src/obs/GResponse.cpp
| ... | ... | @@ -175,7 +175,7 @@ double GResponse::convolve(const GModelSky& model, |
| 175 | 175 | const bool& grad) const |
| 176 | 176 | { |
| 177 | 177 | // Set number of iterations for Romberg integration. |
| 178 | - static const int iter = 4; | |
| 178 | + static const int iter = 5; | |
| 179 | 179 | |
| 180 | 180 | // Initialise result |
| 181 | 181 | double prob = 0.0; | ... | ... |