-
These are the final modifications for the GammaLib core code review.
-
Add GChatter argument to print() method. The print() method now takes an argument of type GChatter to control the chattiness of the output in a homogenous manner. Pass NORMAL chatter level in __str__ method. Add chatter argument to print() methods. Use GLog::chatter() method to control the chattiness of the log stream operator. Add chatter() methods and provide member access through const references. Add chatter() methods, provide member access through const references, and declare one liners as inline methods. The chatter() methods control the new m_chatter attribute that is used to control the chattiness of the object's print() methods. name() and version() methods return const references. logFileOpen() method now sets the chattiness from the applications's chatter parameter, and name() and version() methods now return a const reference.
-
The environment variable CALDB may conflict with an existing Fermi CALDB environment variable. I therefore introduced a GAMMALIB_CALDB environment variable that takes precedence over CALDB. The GAMMALIB_CALDB environement variable will be used in the initialisation script, so that conflicts are solved. One can always change this environment variable later, or undefine it so that CALDB will be used. The GCaldb initialisation constructor will first search for GAMMALIB_CALDB, and only if the environment variable is not found it will search for CALDB.
-
I went over all .hpp to make sure that the GBase.hpp file is properly included, and no supoerfluous other includes remain. I also checked that no ostream and GLog friends are no longer available. I went over all .i files to make sure that classes are derived from GBase.
-
The ostream and GLog functions are not defined at the GBase level.
