Justine Devin / gammalib

…ll GModelData derivatives

The CTA response was refactored. GCTAResponse was renamed GCTAResponseIrf, and GCTAResponse became an abstract base class for all possible CTA response functions. GCTAResponseIrf derives from GCTAResponse. Also GCTAResponseCube derives from GCTAResponse.

To make this work, the GObservation::response() method now returns a pointer instead of a reference. The interface definition is such that the pointer never can be NULL. The code has been adapted to comply to this new interface.

Upon reading an XML file, GCTAObservation now determines the appropriate reponse type and calls its reader. If no response is specified in the XML file, GCTAResponseIrf will be used by default.

Adapt the code to the usage of GCaldb for response access.

Now, GCaldb only reads the CALDB environment variable when needed. This allows changing the CALDB environment variable during runtime.

Rename GCaldb::dir to GCaldb::rootdir.

The coding and design conventions (CDC) document was also updated.

The GCOMPointing class is now obsolete as no GPointing class is required anymore. The pointing can now simply be stored in a GSkyDir object.

All methods returning a solid angle are now named solidangle().

The abstract pointing class has been removed as so far no abstract pointing interface is needed.

GEvents
GEventList
  The clobber argument of the save() method is now passed as const
  reference.

GEventCube
  The clobber argument of the save() method and the axis argument of the
  naxis() method are now passed as const references.

The GFits class now derives from GContainer and implements all generic container class methods (at(), size(), isempty(), set(), append(), insert(), remove(), reserve(), extend()). The hashdu() method has been renamed to contains() for compliance with other container classes. The hdu() methods have been renamed to at(), also for compliance. Boolean arguments are now passed as const references, and members are returned as const references. HDU access operators[] have been implemented to access FITS extensions without range checking.

The GSkyPixel class now handles 1D and 2D sky indices. This made the distinctive 1D and 2D methods in GSkyProjection and the derived classes obsolete. Now, all projection classes take GSkyPixel as argument.

The GSkymap class now uses the universal GSkyPixel class. Methods have been renamed consistently. An integer index is now consistently called "sky map index" and the GSkyPixel object is named a "sky map pixel". Methods operating on indices contain now "inx", method operating on sky map pixels "pix".

The GWcslib class has been renamed to GWcs for consistency with the naming convention for GammaLib base classes. All WCS implementations derive now from GWcs. The code has been adapted to this new naming convention.

After renaming GWcs to GSkyProjection the code has been adapted to the new naming convention.

The old scheme with the deadtime correction in the base class led to some irf/npred methods having deadtime correction and others without correction. This definitely was a source of confusion and potential errors. Now, deadtime corrections have to be done at the instrument level, enhancing clarity of the interfaces and flexibility, at the expense of some burden on the instrument specific response class implementation that now has to take care of the proper handling of deadtime.

The previous scheme had some risk of running out of the response array.

Add GChatter argument to print() method.

The print() method now takes an argument of type GChatter to control the chattiness of the output in a homogenous manner.
Pass NORMAL chatter level in __str__ method.
Add chatter argument to print() methods.
Use GLog::chatter() method to control the chattiness of the log stream operator.
Add chatter() methods and provide member access through const references.
Add chatter() methods, provide member access through const references, and declare one liners as inline methods.

The chatter() methods control the new m_chatter attribute that is used to control the chattiness of the object's print() methods.
name() and version() methods return const references.
logFileOpen() method now sets the chattiness from the applications's chatter parameter, and name() and version() methods now return a const reference.

The GModelPar interface has been revisited and the code has been adapted to satisfy the new interface.

Originally, the write() method wrote directly into the source library and did not create a <source> tag. This is now corrected.

The IAQ parameter allows specifying a response file for each observation.

The new method names enhance compatbility with the GPhoton interface and increases the readability.

Instead of using the observed and true attributes of the event and photon as arguments, the event and photon is now passed directly.