Justine Devin / gammalib

…ts for GEbounds::contains() methods.

Added a logger() method that allows setting the logger for an optimizer (and that also allows to set the NULL pointer)

The convert() and set() methods now support time references given in the UTC time system. Using convert() one can now extract for example MJD in the UTC time system. All this needs still to be documented.

Following the recent bug discovery in the operator-= I added a bunch of unit tests to make sure that the GEnergy class is indeed doing what it is expected to do.

The coding and design conventions (CDC) document was also updated.

The events() set method now takes a const reference instead of a const pointer as argument. Some methods have now been defined inline.

GTime
  The secs() method now returns a const reference.

GTimeReference
  The load constructor and the read() and write() methods take
  a const reference instead of a pointer.

GGti
  The read() and write() methods now use references instead of
  pointers. The clobber argument in the save() method is passed
  as const reference.

GEbounds
  The read() and write() methods now use FITS references instead
  of pointers. The clobber argument in the save() method is passed
  as const reference.

GPhoton
  Add mcid argument to Photon constructor (defaults to -1).

GTestSuites
  The GTestSuites class now derives from GContainer and implements
  the usual container class methods (at(), size(), isempty(),
  set(), append(), insert(), remove(), reserve() and extend()).
  The operator[] now returns pointers to GTestSuite. The name()
  and timestamp() methods now return const references.

GTestSuite
  The GTestSuite class now derives from GBase. This implies that
  the clone() method needs to be implemented for derived classes.
  The test_assert() method now takes a const reference for the
  boolean argument. The name(), errors(), failures(), and
  timestamp() methods return const references. The obsolete
  add_test() method has been removed.

The unit tests have been updated to conform to the new interfaces.

The load constructor creates an instance of the GEnergies class by loading the energy information from a FITS file.

Added the methods load(), save(), read() and write() to enable saving and loading of energies into a FITS file.

The GEnergies container class holds objects of type GEnergy.

GTimes is now a GammaLib compliant container class that derives from GContainer. All required methods have been implemented, and a unit test has been added.

The GPhotons class now derived from GContainer, and a compliant container class interface has been implemented for this class.

This reverts commit 813252eb589e317fd139d0cdde4f20bdd7959ef2.

The GModels model access operator[] now returns a reference instead of a pointer. This needed a couple of minor adjustments of the code.

The reference returned by the GObservations::models() method is now declared const. The unit tests had to be slightly adapted to accomodate this interface change.

The container class method name pop() was changed to remove() to be complatible with the Python syntax for lists.

The add() method has been renamed to merge() to make clear that this method performs a merging of intervals.

The Doxygen documentation has been improved, syntax errors have been corrected, and the language usage is more concise.

The test

double mjd_ref = 55197.000766018518519;
double t       = 123456.789;
time.secs(t);
test_value(time.convert(GTimeReference(0.0, "s", "TT", "LOCAL")), t + mjd_ref*86400.0);

fails on OpenSolaris (value-expected = 9.53674e-07). We thus set the required precision to 1e-6 to pass the test.

It is not very satisfactory that an apparently identical operation leads to different results on OpenSolaris.

The GTime class has now a constructor that takes a double precision value as single argument. The argument is the time in the native reference in either seconds or days.

Adapt the code to the new interface.

On Mac OS X using the Apple gcc compiler, we need to include gomp_thread_attr in case we want OpenMP support. Some code has been added to the configure script to detect this specific need, and only if this specific need is met the variable HAVE_OPENMP_DARWIN_KLUGE is defined in config.h. We use then this varaible to include (or not) the following sequence:
#ifdef HAVE_OPENMP_DARWIN_KLUGE
#include <pthread.h>
pthread_attr_t gomp_thread_attr;
#endif

The duplication of this section led to compilation problems on Mac OS 10.6 using gcc 4.3 and gcc 4.4.