Make sure that old library path is kept on Mac OS X (#2420)

Jürgen Knödlseder
1 parent e8e560d5
Showing 6 changed files with 29 additions and 46 deletions
ChangeLog
NEWS
doc/source/admin/release_history/1.6.rst
src/ctools-init.csh
src/ctools-init.sh
src/ctools-setup.in
-2018-04-09
+2018-04-10
         * Version 1.6.0 released
         ========================
+        Keep existing library path in installation script on Mac OS X (#2420)
         Add show_rmf.py example script
         Allow specifying of input sky map in ctskymap (#2311)
         Add ras() and decs() methods to csobsinfo (#2313)
 New Features and Important Changes in ctools 1.6.0
-9 April 2018
+10 April 2018
 Introduction
@@ -11,7 +11,7 @@ ctools release with respect to the precedent release.
 Configuration
 -------------
-None
+Keep existing library path in installation script on Mac OS X (#2420)
 Python interface
@@ -16,7 +16,8 @@ In particular, this release provides:
 Bug fixes
 ---------
-* ...
+* [`2420 <https://cta-redmine.irap.omp.eu/issues/2420>`_] -
+  Keep existing library path in installation script on Mac OS X
 Improvements
-# Filename: ctools-init.csh
+# Filename:    ctools-init.csh
 # Description: C-shell flavor initialization for ctools
 #              runs ctools-setup to generate a temporary csh script
 #              tailored specifically to this user and ctools
-# Filename: ctools-init.sh
+# Filename:    ctools-init.sh
 # Description: Bourne-shell flavor initialization for ctools.
 #              Runs ctools-setup to generate a sh script tailored
 #              specifically to this user and ctools installation,
-#! /bin/sh
-#    Filename: ctools-setup(.in)
+#  Filename:   ctools-setup(.in)
 # Description: Writes an initialization script for ctools software
 #              which is custom fit to the user and the particular
 #              software installation. Note that this script is
@@ -98,12 +97,10 @@ fi
 #
 # Set LD_LIBRARY_PATH
 # ===================
-if [ "x$LD_LIBRARY_PATH" = x ]; then
-  LD_LIBRARY_PATH="$ctools_lib"
+if [ -z "${LD_LIBRARY_PATH}" ]; then
+  LD_LIBRARY_PATH=$ctools_lib
 else
-  LD_LIBRARY_PATH=`echo ":$LD_LIBRARY_PATH:" | \
-    sed "s%:$ctools_lib:%:%g" | sed "s%::*$%%"`
-  LD_LIBRARY_PATH="$ctools_lib$LD_LIBRARY_PATH"
+  LD_LIBRARY_PATH=$ctools_lib:$LD_LIBRARY_PATH
 fi
 #
@@ -111,20 +108,17 @@ fi
 # =================================
 case $uname_system in
   Darwin*)
-    if [ "x$DYLD_LIBRARY_PATH" = x ]; then
-         DYLD_LIBRARY_PATH="$ctools_lib"
+    if [ -z "${DYLD_LIBRARY_PATH}" ]; then
+      DYLD_LIBRARY_PATH=$ctools_lib
     else
-      DYLD_LIBRARY_PATH=`echo ":$DYLD_LIBRARY_PATH:" | \
-        sed "s%:$ctools_lib:%:%g" | sed "s%::*$%%"`
-      DYLD_LIBRARY_PATH="$ctools_lib$DYLD_LIBRARY_PATH"
+      DYLD_LIBRARY_PATH=$ctools_lib:$DYLD_LIBRARY_PATH
     fi
     ;;
   CYGWIN*)
-    if [ "x$PATH" = x ]; then
-      PATH="$ctools_lib"
+    if [ -z "${PATH}" ]; then
+      PATH=$ctools_lib
     else
-      PATH=`echo ":$PATH:" | sed "s%:$ctools_lib:%:%g" | sed "s%::*$%%"`
-      PATH="$ctools_lib$PATH"
+      PATH=$ctools_lib:$PATH
     fi
     ;;
 esac
@@ -132,41 +126,28 @@ esac
 #
 # Set PYTHONPATH
 # ==============
-if [ "x$PYTHONPATH" = x ]; then
-  PYTHONPATH="$python_dir"
+if [ -z "${PYTHONPATH}" ]; then
+  PYTHONPATH=$python_dir:$python_exec_dir
 else
-  PYTHONPATH=`echo ":$PYTHONPATH:" | \
-    sed "s%:$python_dir:%:%g" | sed "s%::*$%%"`
-  PYTHONPATH="$python_dir$PYTHONPATH"
-fi
-if [ "x$PYTHONPATH" = x ]; then
-  PYTHONPATH="$python_exec_dir"
-else
-  PYTHONPATH=`echo ":$PYTHONPATH:" | \
-    sed "s%:$python_exec_dir:%:%g" | sed "s%::*$%%"`
-  PYTHONPATH="$python_exec_dir$PYTHONPATH"
+  PYTHONPATH=$python_dir:$python_exec_dir:$PYTHONPATH
 fi
 #
 # Set PKG_CONFIG_PATH
 # ===================
-if [ "x$PKG_CONFIG_PATH" = x ]; then
-  PKG_CONFIG_PATH="$pkgconfig_dir"
+if [ -z "${PKG_CONFIG_PATH}" ]; then
+  PKG_CONFIG_PATH=$pkgconfig_dir
 else
-  PKG_CONFIG_PATH=`echo ":$PKG_CONFIG_PATH:" | \
-    sed "s%:$pkgconfig_dir:%:%g" | sed "s%::*$%%"`
-  PKG_CONFIG_PATH="$pkgconfig_dir$PKG_CONFIG_PATH"
+  PKG_CONFIG_PATH=$pkgconfig_dir:$PKG_CONFIG_PATH
 fi
 #
 # Set PATH
 # ========
-if [ "x$PATH" = x ]; then
-  PATH="$ctools_bin"
+if [ -z "${PATH}" ]; then
+  PATH=$ctools_bin
 else
-  PATH=`echo ":$PATH:" | \
-    sed "s%:$ctools_bin:%:%g" | sed "s%::*$%%"`
-  PATH="$ctools_bin$PATH"
+  PATH=$ctools_bin:$PATH
 fi
 #
@@ -188,8 +169,8 @@ fi
 #
 # Set CALDB (if not yet set)
 # ==========================
-if [ "x$CALDB" = x ]; then
-  CALDB="$caldb_dir"
+if [ -z "${CALDB}" ]; then
+  CALDB=$caldb_dir
 fi
 #