Marianne Lemoine / ctools

Commit c5362de99f6a7a96c5088d67207768a4b379b4c9

Authored by Jürgen Knödlseder
1 parent eaa75242

Fix ctbin segfault bug for varying energy thresholds (#1850)

Inline Side-by-side
Showing 3 changed files with 18 additions and 4 deletions
ChangeLog
  View file @c5362de
1 -2016-08-12 1 +2016-09-26
2 2
3 * Version 1.2.0 released 3 * Version 1.2.0 released
4 ======================== 4 ========================
5 5
  6 + Fix ctbin segfault bug for varying energy thresholds (#1850)
  7 + Make csresmap enumbins parameter hidden (#1844)
6 Rename ctskymap::map() to ctskymap::skymap() (#1828) 8 Rename ctskymap::map() to ctskymap::skymap() (#1828)
7 - Introduce ctobservation and ctlikelihood base classes (#1828) 9 + Introduce ctobservation and ctlikelihood base classes (#1828, #1846)
8 Remove ctselect::time_reference() method 10 Remove ctselect::time_reference() method
9 Add ctool and cscript pars() methods (#1838) 11 Add ctool and cscript pars() methods (#1838)
10 Fix ctbin::save() bug for empty observation container (#1835) 12 Fix ctbin::save() bug for empty observation container (#1835)
1 New Features and Important Changes in ctools 1.2.0 1 New Features and Important Changes in ctools 1.2.0
2 2
3 -12 August 2016 3 +26 September 2016
4 4
5 5
6 Introduction 6 Introduction
@@ -32,6 +32,14 @@ observation container. The class implements the following methods: @@ -32,6 +32,14 @@ observation container. The class implements the following methods:
32 - next_unbinned_observation() Next unbinned CTA observation in container 32 - next_unbinned_observation() Next unbinned CTA observation in container
33 The following ctools derive from the class: 33 The following ctools derive from the class:
34 - ctbin 34 - ctbin
  35 +- ctbkgcube
  36 +- ctcubemask
  37 +- ctedispcube
  38 +- ctexpcube
  39 +- ctmodel
  40 +- ctobssim
  41 +- ctpsfcube
  42 +- ctselect
35 - ctskymap 43 - ctskymap
36 44
37 The ctlikelihood base class that derives from the ctobservation base class 45 The ctlikelihood base class that derives from the ctobservation base class
@@ -41,6 +49,7 @@ class implements the following methods: @@ -41,6 +49,7 @@ class implements the following methods:
41 - opt() Returns pointer to optimizer 49 - opt() Returns pointer to optimizer
42 - evaluate() Evaluates log-likelihood at a given parameter value 50 - evaluate() Evaluates log-likelihood at a given parameter value
43 The following ctools derive from the class: 51 The following ctools derive from the class:
  52 +- ctbutterfly
44 - cterror 53 - cterror
45 - ctlike 54 - ctlike
46 - cttsmap 55 - cttsmap
@@ -66,6 +75,9 @@ ctool base class, and exposed in Python as _time_reference(). @@ -66,6 +75,9 @@ ctool base class, and exposed in Python as _time_reference().
66 75
67 ctbin - CTA event binning 76 ctbin - CTA event binning
68 ------------------------- 77 -------------------------
  78 +The ctbin segfaulted when running on an observation container with different
  79 +energy thresholds. This problem is now fixed (#1850).
  80 +
69 The clear() method now calls GApplication::clear() to conserve the properties 81 The clear() method now calls GApplication::clear() to conserve the properties
70 of the tool (#1835). 82 of the tool (#1835).
71 83
cscripts/csresmap.par
  View file @c5362de
@@ -35,7 +35,7 @@ outmap, f, a, resmap.fits,,, "Output residual map file" @@ -35,7 +35,7 @@ outmap, f, a, resmap.fits,,, "Output residual map file"
35 ebinalg, s, h, LOG,LIN|LOG|FILE,, "Binning algorithm" 35 ebinalg, s, h, LOG,LIN|LOG|FILE,, "Binning algorithm"
36 emin, r, a, 0.1,,, "Lower energy limit (TeV)" 36 emin, r, a, 0.1,,, "Lower energy limit (TeV)"
37 emax, r, a, 100.0,,, "Upper energy limit (TeV)" 37 emax, r, a, 100.0,,, "Upper energy limit (TeV)"
38 -enumbins, i, a, 20,,, "Number of energy bins (0=unbinned)" 38 +enumbins, i, h, 20,,, "Number of model cube energy bins"
39 ebinfile, f, a, NONE,,, "Name of the file containing the energy bin definition" 39 ebinfile, f, a, NONE,,, "Name of the file containing the energy bin definition"
40 coordsys, s, a, CEL,CEL|GAL,, "Coordinate System" 40 coordsys, s, a, CEL,CEL|GAL,, "Coordinate System"
41 proj, s, a, CAR,AIT|AZP|CAR|MER|MOL|STG|TAN,, "Projection method" 41 proj, s, a, CAR,AIT|AZP|CAR|MER|MOL|STG|TAN,, "Projection method"