Luigi Tibaldo / gammalib

Put the type() and region() methods in the GModelSpatial base class to avoid code duplication. The region is now set by the derived classes using the pure virtual set_region() method.

The GModelSpatial::region() method returns a pointer to a sky region that fully encloses the spatial model component.

…ients argument (#1847)

The eval_gradients() methods duplicate much of the code of the eval() methods. To increase the maintainability of the code, the eval_gradients() methods have been removed, and the computation of partial derivatives is now done by the eval() methods if the optional gradients argument is set to true.

It seems better to not introduce the alias method but to use a type constructor instead. This allows writing out the same model type that was read in, enhancing the compatibility with the legacy XML format.

The following new names have been introduced for the spatial model components:
* "PointSource" (alias: "SkyDirFunction")
* "RadialDisk" (alias: "DiskFunction")
* "RadialGaussian" (alias: "GaussFunction")
* "RadialShell" (alias: "ShellFunction")
* "EllipticalDisk"
* "EllipticalGaussian" (alias: "EllipticalGauss")
* "DiffuseIsotropic" (alias: "ConstantValue")
* "DiffuseMap" (alias: "SpatialMap")
* "DiffuseMapCube" (alias: "MapCubeFunction")

Conflicts:
	ChangeLog
	inst/cta/src/GCTAResponse_helpers.cpp
	inst/cta/src/GCTASupport.hpp

The binned analysis looks okay, but unbinned shows a strange behaviour for the semiminor axis parameter which results in a strong dependency of Npred on the semiminor axis value. This seems to prevent a nice convergence in unbinned mode.

There is also an open issue to be solved related to the possibility that the minor axis is larger than the major axis. The actual code assumes that minor axis < major axis. If this is not fulfilled, the omega arc computations will be wrong.

Any elliptical model should be defined by semiminor and semimajor axes, these are in fact used in the CTA response computation. Hence they should live in the baseclass, not the derived class.

…or the observation Python module.

The classname() method returns in a human readable format the class name. This method is needed for full automatic typecasting in Python. Full automatic typecasting has for the moment been implemented for the observation module.

Add GChatter argument to print() method.

The print() method now takes an argument of type GChatter to control the chattiness of the output in a homogenous manner.
Pass NORMAL chatter level in __str__ method.
Add chatter argument to print() methods.
Use GLog::chatter() method to control the chattiness of the log stream operator.
Add chatter() methods and provide member access through const references.
Add chatter() methods, provide member access through const references, and declare one liners as inline methods.

The chatter() methods control the new m_chatter attribute that is used to control the chattiness of the object's print() methods.
name() and version() methods return const references.
logFileOpen() method now sets the chattiness from the applications's chatter parameter, and name() and version() methods now return a const reference.

The eval() and eval_gradients() methods now take a GPhoton object as argument to allow the implementation of energy and time dependent source morphologies.

GEnergy and GTime objects have been added to the mc() method interface to support equally the implementation of energy and time dependent source morphologies.

So far, no class really implements energy and time dependent source morphologies, but now we have the infrastructure to do so.

The GModelPar interface has been revisited and the code has been adapted to satisfy the new interface.

The minor() and major() methods produced problems on FreeBSD where both functions are predefined macros.

I quickly went over the code before integration to make it compliant to the coding standards. Most of the modifications were cosmetical (related to code formating)