Maria Haupt / ctools

A symbolic link is now created by setup.py that points towards the wrapper library directory. We add this directory now to the PYTHONPATH so that no double compilation is needed anymore.

A Darwin kluge consisted of linking statically with the ctools library for unit testing. It turned out that this is no longer necessary, so I removed the Darwin kluge of static linking.

Furthermore, a post-processing step was added that creates a symbolic link to the directory that contains the shared wrapper library. In that way, we do not need a double compilation anymore (before, we compiled once for the install and a second time for the unit test). This should now speed up the unit testing step.

As the outfile can now also be an XML observation definition file, we add this information to the query.

Adapt the simplified Python wrapper detection method from GammaLib.

Initially, Python was not correctly detected on Mac OS X due to an old version of AM_PATH_PYTHON(bug #437). A kluge has been added that will detect Python nevertheless.

The gcc 4.2.x compiler series has a feature where libgomp.so.1 cannot be dlopen()ed. In this case, the OpenMP support does not properly work in ctools. We try detecting this, but restrict the analysis so far on Linux systems.

As Python3 replaces the print statement by a print() function, the previous code was not compatible with Python3. We thus replaced all print statements by calls to sys.stdout.write() so that the code works  both for Python2 and Python3.

Add two variables PYTHON_OPEN and PYTHON_CLOSE that are either " " and "" (for Python 2) or "(" and ")" (for Python 3). These variables are used in setup.py to toggle between the Python 2 print statement and the Python 3 print function.

In Python3, the print method was replaced by a print() function. We have thus to distinguish between both possibilities during the configuration.

… compiles also correctly on compilers that differ from gcc.

Using the clang compiler, the ctools and gammalib libraries were not found. Adding the paths helps.

For OpenMP to work properly on Mac OS X, the -lgomp library has to be linked. For this purpose, a new variable OPENMP_LIB_LDFLAGS has been created that is set by configure to -lgomp in the presence of OpenMP support.

The ctobssim Makefile.am has been modified to take this parameter into account during linking.

Made code compliant to coding standards and added more text for comments.

Updated also the version number to 00-06-00.

The files were adjusted according to the recent changes in GammaLib.

ctlike now computes the observed number of events and dumps the information just before the predicted number of events into the log file. The difference between the observed and predicted number of events is also given so that one knows immediately if the fit behaved as it should.

This commit closes actions #87 and #88 and the feature #54.

Filenames are now always accessed using the filename() method so that environment variables get correctly expanded.

The prefix is now accessed using the string() method instead of the generic value() method, so that string checkings can be performed.

In case that the observation container holds more than a single observation, ctobssim now outputs an observation definition XML file in addition to the event files. The filenames of the event files will be stored in the observation definition XML file so that subsequent ctools can handle all observational data together.

We use the value() method instead of the filename() method to retrieve the output filename as we do not want to check whether the file exists.

The script cta_make_nodes.py can be used to create the node section of a NodeFunction XML model. It initialises the energy values with a logarithmic binning, and sets initial intensity values using a Crab spectrum based on a power law function.

On Mac OS X, the /bin/sh shell has a builtin echo command that does not recognize the -n option for linefeed supression. To keep the test script portable, the script now uses the echo command installed on the machine (usually in /bin/echo). The which function is used to make sure that the echo command is correctly located.

On FreeBSD, bash is not installed by default, and when it is installed using ports, it is in /usr/local/bin. Using /bin/bash as script directive thus fails to execute the script. Using /bin/sh instead works.