Michael Mayer / gammalib

The coding and design conventions (CDC) document was also updated.

The GCOMPointing class is now obsolete as no GPointing class is required anymore. The pointing can now simply be stored in a GSkyDir object.

All methods returning a solid angle are now named solidangle().

The abstract pointing class has been removed as so far no abstract pointing interface is needed.

GEvents
GEventList
  The clobber argument of the save() method is now passed as const
  reference.

GEventCube
  The clobber argument of the save() method and the axis argument of the
  naxis() method are now passed as const references.

The GFits class now derives from GContainer and implements all generic container class methods (at(), size(), isempty(), set(), append(), insert(), remove(), reserve(), extend()). The hashdu() method has been renamed to contains() for compliance with other container classes. The hdu() methods have been renamed to at(), also for compliance. Boolean arguments are now passed as const references, and members are returned as const references. HDU access operators[] have been implemented to access FITS extensions without range checking.

GTestSuites
  The GTestSuites class now derives from GContainer and implements
  the usual container class methods (at(), size(), isempty(),
  set(), append(), insert(), remove(), reserve() and extend()).
  The operator[] now returns pointers to GTestSuite. The name()
  and timestamp() methods now return const references.

GTestSuite
  The GTestSuite class now derives from GBase. This implies that
  the clone() method needs to be implemented for derived classes.
  The test_assert() method now takes a const reference for the
  boolean argument. The name(), errors(), failures(), and
  timestamp() methods return const references. The obsolete
  add_test() method has been removed.

The unit tests have been updated to conform to the new interfaces.

The GSkyPixel class now handles 1D and 2D sky indices. This made the distinctive 1D and 2D methods in GSkyProjection and the derived classes obsolete. Now, all projection classes take GSkyPixel as argument.

The GSkymap class now uses the universal GSkyPixel class. Methods have been renamed consistently. An integer index is now consistently called "sky map index" and the GSkyPixel object is named a "sky map pixel". Methods operating on indices contain now "inx", method operating on sky map pixels "pix".

The GWcslib class has been renamed to GWcs for consistency with the naming convention for GammaLib base classes. All WCS implementations derive now from GWcs. The code has been adapted to this new naming convention.

After renaming GWcs to GSkyProjection the code has been adapted to the new naming convention.

The old scheme with the deadtime correction in the base class led to some irf/npred methods having deadtime correction and others without correction. This definitely was a source of confusion and potential errors. Now, deadtime corrections have to be done at the instrument level, enhancing clarity of the interfaces and flexibility, at the expense of some burden on the instrument specific response class implementation that now has to take care of the proper handling of deadtime.

…ble in unit tests and use PACKAGE_SOURCE determine in configure instead of abs_top_srcdir as the latter does not exist on older systems.

The previous scheme had some risk of running out of the response array.

The absolute path names are necessary to correctly use the valgrind rule in the test/Makefile. This all is needed to support Sonar, which need valgrind and sonar-runner running from the same directory, which is here the source directory.

…t is run. This directory will be used in unit testing for building absolute path names.

The isconstant() method signals if a model is temporally constant or not. This information can be used at an abstract level to perform yes or no a temporal integration of the model.

Add GChatter argument to print() method.

The print() method now takes an argument of type GChatter to control the chattiness of the output in a homogenous manner.
Pass NORMAL chatter level in __str__ method.
Add chatter argument to print() methods.
Use GLog::chatter() method to control the chattiness of the log stream operator.
Add chatter() methods and provide member access through const references.
Add chatter() methods, provide member access through const references, and declare one liners as inline methods.

The chatter() methods control the new m_chatter attribute that is used to control the chattiness of the object's print() methods.
name() and version() methods return const references.
logFileOpen() method now sets the chattiness from the applications's chatter parameter, and name() and version() methods now return a const reference.

The GModelPar interface has been revisited and the code has been adapted to satisfy the new interface.

This reverts commit 813252eb589e317fd139d0cdde4f20bdd7959ef2.