Michael Mayer / gammalib

…nged GSkyRegion::solidangle() return type.

The mc() method went in endless loops as the exit condition of the while loop was inversed (the method continued looping when the energy was within the valid range and only exited when it was outside).

The eval_gradients() method computed the gradients with respect to the parameter values and not the parameter factors. All gradients have be multiplied by the scales. Also, the gradients are now set to 0 if the parameters are fixed.

Finally, the parameter "Prefactor" was renamed to "Normalization" because the parameter gives the integral flux under the Gaussian, not the prefactor.

The code has been reformated after changing the class names from GPar to GApplicationPar and GPars to GApplicationPars. The renaming has been logged in the ChangeLog file.

(I chose `centre` because there were more `centre` than `center`
around.)

The coding and design conventions (CDC) document was also updated.

The curvature matrix, which is equal to one-half time the Hessian matrix, is evaluated and not the covariance matrix. To make this clean, all covar terms have been renamed to curvature.

Conflicts:
	doc/source/user_manual/modules/model.rst

Initially, there was a unlogic relation between GModels and GOptimizerPars, where GModels derives from GOptimizerPars, but both classes contained different types of objects. GModels is a model container, while GOptimizerPars is a parameter container.

Now, GModels derives directly from GContainer and no longer from GOptimizerPars. The GModels::pars() method has been added to extract a flat array of model parameter pointers into a GOptimizerPars object.

GOptimizerPars, which was abstract before, is now a real container class that also derives from GContainer.

GModelPar is now derived from GOptimzerPars and implements in addition to the base class a read() and write() method that takes an XML element as argument.

The GOptimizePar class has been copied over from GModelPar. The only methods that were not copied were the read() and write() methods for the XML format.

Conflicts:
	inst/lat/test/data/p7v6/crab_model.xml

Although GFitsTable does not derived from GContainer, it is basically a container class for FITS columns. Therefore, the check for existence of an element should be done using the contains() method.

All methods returning a solid angle are now named solidangle().

These are the final modifications for the GammaLib core code review.

The abstract pointing class has been removed as so far no abstract pointing interface is needed.

The events() set method now takes a const reference instead of a const pointer as argument. Some methods have now been defined inline.

GEvents
GEventList
  The clobber argument of the save() method is now passed as const
  reference.

GEventCube
  The clobber argument of the save() method and the axis argument of the
  naxis() method are now passed as const references.