Michael Mayer / gammalib

…onse compontent. Further expanded CTA unit test suite to reading and writing from/to xml to test this feature

…on helper classes. This should avoid using references that are no longer valid (see #1556).

…nged back as expected).

…dependend on model type.

This removes the bias in the pull distribution for shell models with a width that is comparable to the angular resolution (#1521).

Having only 4 integration iterations leads to an exception as the default order for integration is 5. Hence the number of integration iterations was switched to 5 to prevent this problem.

Solves #1472.

… "xml_has_par" function and made reading of information in observation definition file optional (so that for example energies or ROI can be missing).

…owed an offset, see #1248)

The setting of XML filenames upon loading of response components leads to an automatic saving of all response file paths in an XML file. This is very constraining and should be avoided. We therefore only save XML filenames that have been loaded, so that an exact copy of the input file can be written on output.

…sponse function in the XML file.

Before, the result of srcEng.log10TeV() was directly passed to the cta_nedisp_kern constructor, which stores only a reference to the value instead of the value. Since srcEng.log10TeV() does not return a reference but a value, it is not assured that the actual memory cell containing the value is still valid. This led to problems on CentOS 7.

Now, a local copy is created.

In the future we may avoid storing references and store directly the values. This should result in a negligible overhead, as the actual eval() method is called multiple times. We may still store references for large objects, but at least for simple arguments we should store by value.

…servation definition XML files

Conflicts:
	ChangeLog
	inst/cta/src/GCTAResponse_helpers.cpp
	inst/cta/src/GCTASupport.hpp

… radians; this led to convergence problems with the shell model).

Only the model-based integrations allow a proper and easy handling of the elliptical models.

…strange Npred profile.

The binned analysis looks okay, but unbinned shows a strange behaviour for the semiminor axis parameter which results in a strong dependency of Npred on the semiminor axis value. This seems to prevent a nice convergence in unbinned mode.

There is also an open issue to be solved related to the possibility that the minor axis is larger than the major axis. The actual code assumes that minor axis < major axis. If this is not fulfilled, the omega arc computations will be wrong.