Do no longer set missing boundaries in ctool::get_observations and ctool::setup_observations (#2686)

Jürgen Knödlseder
1 parent ea342bf1
Showing 4 changed files with 15 additions and 13 deletions
ChangeLog
NEWS
doc/source/admin/release_history/1.6.rst
src/support/ctool.cpp
-2018-09-21
+2018-09-22
         * Version 1.6.0 released
         ========================
+        Do no longer set missing boundaries in ctool::get_observations and
+          ctool::setup_observations (#2686)
         Unnormalize background cube values in ctbkgcube (#2685)
         Account for varying energy thresholds in ctbin weight computation (#2685)
         Add ctbkgcube::cntcube() method (#2685)
 New Features and Important Changes in ctools 1.6.0
-21 September 2018
+22 September 2018
 Introduction
@@ -140,6 +140,14 @@ None
 ctselect - CTA event selection
 ------------------------------
+Do no longer set missing energy and RoI boundaries in ctool::get_observations
+and ctool::setup_observations since this led to a problem in ctselect. For
+H.E.S.S. data, where the boundaries are not set, the boundaries were preset
+with the User parameters, which made event selection with the usepnt=no option
+impossible. It is not clear why the setting of missing boundaries was introduced
+but it looks like a dangerous thing to do. The setting has therefore been
+removed (#2686).
+
 Avoid an error in case that the RoI radius is identical to the existing RoI
 radius (#2682).
@@ -19,6 +19,9 @@ In particular, this release provides:
 Bug fixes
 ---------
+* [`2686 <https://cta-redmine.irap.omp.eu/issues/2686>`_] -
+  Do no longer set missing boundaries in ``ctool::get_observations`` and
+  ``ctool::setup_observations``
 * [`2682 <https://cta-redmine.irap.omp.eu/issues/2682>`_] -
   Avoid :ref:`ctselect` error in case that RoI radius is unchanged
 * [`2652 <https://cta-redmine.irap.omp.eu/issues/2652>`_] -
@@ -388,11 +388,6 @@ void ctool::sync_pfiles(void)
  * observations in the container. In case that no response information is
  * required, the @p response argument should be set to @p false. See the
  * set_response() method for details.
- *
- *
- * The method will also setup the observation boundaries for all CTA
- * observations in the container that contain event lists. For details, see
- * the set_obs_bounds() method.
  ***************************************************************************/
 void ctool::setup_observations(GObservations& obs,
                                const bool&    response,
@@ -480,9 +475,6 @@ void ctool::setup_observations(GObservations&amp; obs,
         set_response(obs);
     }
-    // Setup boundaries for all CTA observations containing event lists
-    set_obs_bounds(obs);
-
     // Return
     return;
 }
@@ -1736,9 +1728,6 @@ GObservations ctool::get_observations(const bool&amp; get_response)
             } // endif: response was required
-            // Set observation boundary parameters (emin, emax, rad)
-            set_obs_bounds(obs);
-
             // Signal that XML file should be used for storage
             m_use_xml = true;