Commit 3e233a4c1ed5c526978aa391e8c5bfdb5e11cb6c
1 parent
ffa29eec
Add max_iter parameter to ctbutterfly, cterror, ctlike, cttsmap, ctulimit and cstsmapsplit
Showing
10 changed files
with
38 additions
and
2 deletions
ChangeLog
| 1 | -2018-12-12 | 1 | +2018-01-15 |
| 2 | 2 | ||
| 3 | * Version 1.6.0 released | 3 | * Version 1.6.0 released |
| 4 | ======================== | 4 | ======================== |
| 5 | 5 | ||
| 6 | + Add max_iter parameter to ctbutterfly, cterror, ctlike, cttsmap, | ||
| 7 | + ctulimit and cstsmapsplit | ||
| 6 | ctbkgcube now requires an input counts cube (#2763) | 8 | ctbkgcube now requires an input counts cube (#2763) |
| 7 | CTA background rates are now per ontime (#2758) | 9 | CTA background rates are now per ontime (#2758) |
| 8 | Add exclusion_map() methods to ctskymap, csphagen, cslightcrv and | 10 | Add exclusion_map() methods to ctskymap, csphagen, cslightcrv and |
NEWS
| 1 | New Features and Important Changes in ctools 1.6.0 | 1 | New Features and Important Changes in ctools 1.6.0 |
| 2 | 2 | ||
| 3 | -12 December 2018 | 3 | +15 January 2019 |
| 4 | 4 | ||
| 5 | 5 | ||
| 6 | Introduction | 6 | Introduction |
| @@ -99,6 +99,9 @@ normalisation is correct (#2685). | @@ -99,6 +99,9 @@ normalisation is correct (#2685). | ||
| 99 | 99 | ||
| 100 | ctbutterfly - Generate butterfly diagrams | 100 | ctbutterfly - Generate butterfly diagrams |
| 101 | ----------------------------------------- | 101 | ----------------------------------------- |
| 102 | +Add hidden "max_iter" parameter to allow control of the number of fit | ||
| 103 | +iterations. | ||
| 104 | + | ||
| 102 | Add hidden "like_accuracy" parameter to allow control of the accuracy of | 105 | Add hidden "like_accuracy" parameter to allow control of the accuracy of |
| 103 | the maximum log-likelikelihood value (#2662). | 106 | the maximum log-likelikelihood value (#2662). |
| 104 | 107 | ||
| @@ -115,6 +118,9 @@ None | @@ -115,6 +118,9 @@ None | ||
| 115 | 118 | ||
| 116 | cterror - Likelihood profile error computation | 119 | cterror - Likelihood profile error computation |
| 117 | ---------------------------------------------- | 120 | ---------------------------------------------- |
| 121 | +Add hidden "max_iter" parameter to allow control of the number of fit | ||
| 122 | +iterations. | ||
| 123 | + | ||
| 118 | Add hidden "like_accuracy" parameter to allow control of the accuracy of | 124 | Add hidden "like_accuracy" parameter to allow control of the accuracy of |
| 119 | the maximum log-likelikelihood value (#2662). | 125 | the maximum log-likelikelihood value (#2662). |
| 120 | 126 | ||
| @@ -134,6 +140,9 @@ in the time domain (#2713). | @@ -134,6 +140,9 @@ in the time domain (#2713). | ||
| 134 | 140 | ||
| 135 | ctlike - Maximum likelihood fitting | 141 | ctlike - Maximum likelihood fitting |
| 136 | ----------------------------------- | 142 | ----------------------------------- |
| 143 | +Add hidden "max_iter" parameter to allow control of the number of fit | ||
| 144 | +iterations. | ||
| 145 | + | ||
| 137 | Add hidden "like_accuracy" parameter to allow control of the accuracy of | 146 | Add hidden "like_accuracy" parameter to allow control of the accuracy of |
| 138 | the maximum log-likelikelihood value (#2662). | 147 | the maximum log-likelikelihood value (#2662). |
| 139 | 148 | ||
| @@ -225,12 +234,18 @@ accurately computes the distances between sky map pixels (#2309). | @@ -225,12 +234,18 @@ accurately computes the distances between sky map pixels (#2309). | ||
| 225 | 234 | ||
| 226 | cttsmap - Generation of Test Statistic map | 235 | cttsmap - Generation of Test Statistic map |
| 227 | ------------------------------------------ | 236 | ------------------------------------------ |
| 237 | +Add hidden "max_iter" parameter to allow control of the number of fit | ||
| 238 | +iterations. | ||
| 239 | + | ||
| 228 | Add hidden "like_accuracy" parameter to allow control of the accuracy of | 240 | Add hidden "like_accuracy" parameter to allow control of the accuracy of |
| 229 | the maximum log-likelikelihood value (#2662). | 241 | the maximum log-likelikelihood value (#2662). |
| 230 | 242 | ||
| 231 | 243 | ||
| 232 | ctulimit - Compute upper limit | 244 | ctulimit - Compute upper limit |
| 233 | ------------------------------ | 245 | ------------------------------ |
| 246 | +Add hidden "max_iter" parameter to allow control of the number of fit | ||
| 247 | +iterations. | ||
| 248 | + | ||
| 234 | Add hidden "like_accuracy" parameter to allow control of the accuracy of | 249 | Add hidden "like_accuracy" parameter to allow control of the accuracy of |
| 235 | the maximum log-likelikelihood value (#2662). | 250 | the maximum log-likelikelihood value (#2662). |
| 236 | 251 | ||
| @@ -458,6 +473,9 @@ None | @@ -458,6 +473,9 @@ None | ||
| 458 | 473 | ||
| 459 | cstsmapsplit - Prepare split Test Statistic computation | 474 | cstsmapsplit - Prepare split Test Statistic computation |
| 460 | ------------------------------------------------------- | 475 | ------------------------------------------------------- |
| 476 | +Add hidden "max_iter" parameter to allow control of the number of fit | ||
| 477 | +iterations. | ||
| 478 | + | ||
| 461 | Add hidden "like_accuracy" parameter to allow control of the accuracy of | 479 | Add hidden "like_accuracy" parameter to allow control of the accuracy of |
| 462 | the maximum log-likelikelihood value (#2662). | 480 | the maximum log-likelikelihood value (#2662). |
| 463 | 481 |
cscripts/cstsmapsplit.par
| @@ -29,6 +29,7 @@ edisp, b, h, no,,, "Apply energy dispersion?" | @@ -29,6 +29,7 @@ edisp, b, h, no,,, "Apply energy dispersion?" | ||
| 29 | errors, b, h, no,,, "Compute/store parameter errors?" | 29 | errors, b, h, no,,, "Compute/store parameter errors?" |
| 30 | statistic, s, h, DEFAULT,DEFAULT|CSTAT|WSTAT|CHI2,, "Optimization statistic" | 30 | statistic, s, h, DEFAULT,DEFAULT|CSTAT|WSTAT|CHI2,, "Optimization statistic" |
| 31 | like_accuracy, r, h, 0.005,1.0e-30,1.0, "Absolute accuracy of maximum likelihood value" | 31 | like_accuracy, r, h, 0.005,1.0e-30,1.0, "Absolute accuracy of maximum likelihood value" |
| 32 | +max_iter, i, h, 50,1,1000, "Maximum number of fit iterations" | ||
| 32 | outmap, f, a, tsmap.fits,,, "Output Test Statistic map file" | 33 | outmap, f, a, tsmap.fits,,, "Output Test Statistic map file" |
| 33 | bins_per_job, i, a, 5,,, "Number of TS map bins per task" | 34 | bins_per_job, i, a, 5,,, "Number of TS map bins per task" |
| 34 | compute_null, b, a, yes,,,"Compute null hypothesis first?" | 35 | compute_null, b, a, yes,,,"Compute null hypothesis first?" |
doc/source/admin/release_history/1.6.rst
| @@ -44,6 +44,9 @@ Bug fixes | @@ -44,6 +44,9 @@ Bug fixes | ||
| 44 | Improvements | 44 | Improvements |
| 45 | ------------ | 45 | ------------ |
| 46 | 46 | ||
| 47 | +* Add ``max_iter`` parameter to :ref:`ctbutterfly`, :ref:`cterror`, | ||
| 48 | + :ref:`ctlike`, :ref:`cttsmap`, :ref:`ctulimit`, and :ref:`cstsmapsplit` | ||
| 49 | + to allow controlling the maximum number of fit iterations. | ||
| 47 | * [`2763 <https://cta-redmine.irap.omp.eu/issues/2763>`_] - | 50 | * [`2763 <https://cta-redmine.irap.omp.eu/issues/2763>`_] - |
| 48 | :ref:`ctbkgcube` now requires an input counts cube | 51 | :ref:`ctbkgcube` now requires an input counts cube |
| 49 | * [`2725 <https://cta-redmine.irap.omp.eu/issues/2725>`_] - | 52 | * [`2725 <https://cta-redmine.irap.omp.eu/issues/2725>`_] - |
doc/source/users/reference_manual/ctbutterfly.rst
| @@ -100,6 +100,9 @@ General parameters | @@ -100,6 +100,9 @@ General parameters | ||
| 100 | log likelihood value. Converserly, decreasing the value will result in less | 100 | log likelihood value. Converserly, decreasing the value will result in less |
| 101 | iterations at the expense of a less accurate maximum likelihood value. | 101 | iterations at the expense of a less accurate maximum likelihood value. |
| 102 | 102 | ||
| 103 | +``(max_iter = 50) [integer]`` | ||
| 104 | + Maximum number of fit iterations. | ||
| 105 | + | ||
| 103 | ``(matrix = "NONE") [file]`` | 106 | ``(matrix = "NONE") [file]`` |
| 104 | Input covariance matrix file (not used) | 107 | Input covariance matrix file (not used) |
| 105 | 108 |
doc/source/users/reference_manual/ctlike.rst
| @@ -111,6 +111,9 @@ General parameters | @@ -111,6 +111,9 @@ General parameters | ||
| 111 | log likelihood value. Converserly, decreasing the value will result in less | 111 | log likelihood value. Converserly, decreasing the value will result in less |
| 112 | iterations at the expense of a less accurate maximum likelihood value. | 112 | iterations at the expense of a less accurate maximum likelihood value. |
| 113 | 113 | ||
| 114 | +``(max_iter = 50) [integer]`` | ||
| 115 | + Maximum number of fit iterations. | ||
| 116 | + | ||
| 114 | ``(fix_spat_for_ts = no) [boolean]`` | 117 | ``(fix_spat_for_ts = no) [boolean]`` |
| 115 | Fix spatial parameters for TS computation. | 118 | Fix spatial parameters for TS computation. |
| 116 | 119 |
doc/source/users/reference_manual/cttsmap.rst
| @@ -80,6 +80,9 @@ General parameters | @@ -80,6 +80,9 @@ General parameters | ||
| 80 | log likelihood value. Converserly, decreasing the value will result in less | 80 | log likelihood value. Converserly, decreasing the value will result in less |
| 81 | iterations at the expense of a less accurate maximum likelihood value. | 81 | iterations at the expense of a less accurate maximum likelihood value. |
| 82 | 82 | ||
| 83 | +``(max_iter = 50) [integer]`` | ||
| 84 | + Maximum number of fit iterations. | ||
| 85 | + | ||
| 83 | ``(usepnt = no) [boolean]`` | 86 | ``(usepnt = no) [boolean]`` |
| 84 | Use CTA pointing direction for map centre instead of xref/yref parameters? | 87 | Use CTA pointing direction for map centre instead of xref/yref parameters? |
| 85 | 88 |
src/ctbutterfly/ctbutterfly.par
| @@ -36,6 +36,7 @@ fit, b, h, no,,, "Perform maximum likelihood fitting?" | @@ -36,6 +36,7 @@ fit, b, h, no,,, "Perform maximum likelihood fitting?" | ||
| 36 | confidence, r, h, 0.68,0.0,1.0, "Confidence level" | 36 | confidence, r, h, 0.68,0.0,1.0, "Confidence level" |
| 37 | statistic, s, h, DEFAULT,DEFAULT|CSTAT|WSTAT|CHI2,, "Optimization statistic" | 37 | statistic, s, h, DEFAULT,DEFAULT|CSTAT|WSTAT|CHI2,, "Optimization statistic" |
| 38 | like_accuracy, r, h, 0.005,1.0e-30,1.0, "Absolute accuracy of maximum likelihood value" | 38 | like_accuracy, r, h, 0.005,1.0e-30,1.0, "Absolute accuracy of maximum likelihood value" |
| 39 | +max_iter, i, h, 50,1,1000, "Maximum number of fit iterations" | ||
| 39 | matrix, f, h, NONE,,, "Input covariance Matrix FITS file" | 40 | matrix, f, h, NONE,,, "Input covariance Matrix FITS file" |
| 40 | 41 | ||
| 41 | # | 42 | # |
src/ctlike/ctlike.par
| @@ -34,6 +34,7 @@ outcovmat, f, h, NONE,,, "Output covariance matrix FITS file" | @@ -34,6 +34,7 @@ outcovmat, f, h, NONE,,, "Output covariance matrix FITS file" | ||
| 34 | statistic, s, h, DEFAULT,DEFAULT|CSTAT|WSTAT|CHI2,, "Optimization statistic" | 34 | statistic, s, h, DEFAULT,DEFAULT|CSTAT|WSTAT|CHI2,, "Optimization statistic" |
| 35 | refit, b, h, no,,, "Do refitting?" | 35 | refit, b, h, no,,, "Do refitting?" |
| 36 | like_accuracy, r, h, 0.005,1.0e-30,1.0, "Absolute accuracy of maximum likelihood value" | 36 | like_accuracy, r, h, 0.005,1.0e-30,1.0, "Absolute accuracy of maximum likelihood value" |
| 37 | +max_iter, i, h, 50,1,1000, "Maximum number of fit iterations" | ||
| 37 | fix_spat_for_ts, b, h, no,,, "Fix spatial parameters for TS computation?" | 38 | fix_spat_for_ts, b, h, no,,, "Fix spatial parameters for TS computation?" |
| 38 | 39 | ||
| 39 | # | 40 | # |
src/cttsmap/cttsmap.par
| @@ -34,6 +34,7 @@ outmap, f, a, tsmap.fits,,, "Output Test Statistic map file" | @@ -34,6 +34,7 @@ outmap, f, a, tsmap.fits,,, "Output Test Statistic map file" | ||
| 34 | errors, b, h, no,,, "Compute and store parameter errors?" | 34 | errors, b, h, no,,, "Compute and store parameter errors?" |
| 35 | statistic, s, h, DEFAULT,DEFAULT|CSTAT|WSTAT|CHI2,, "Optimization statistic" | 35 | statistic, s, h, DEFAULT,DEFAULT|CSTAT|WSTAT|CHI2,, "Optimization statistic" |
| 36 | like_accuracy, r, h, 0.005,1.0e-30,1.0, "Absolute accuracy of maximum likelihood value" | 36 | like_accuracy, r, h, 0.005,1.0e-30,1.0, "Absolute accuracy of maximum likelihood value" |
| 37 | +max_iter, i, h, 50,1,1000, "Maximum number of fit iterations" | ||
| 37 | 38 | ||
| 38 | # | 39 | # |
| 39 | # Spatial binning parameters | 40 | # Spatial binning parameters |