Nathan Kelley-Hoskins / gammalib

Before, the result of srcEng.log10TeV() was directly passed to the cta_nedisp_kern constructor, which stores only a reference to the value instead of the value. Since srcEng.log10TeV() does not return a reference but a value, it is not assured that the actual memory cell containing the value is still valid. This led to problems on CentOS 7.

Now, a local copy is created.

In the future we may avoid storing references and store directly the values. This should result in a negligible overhead, as the actual eval() method is called multiple times. We may still store references for large objects, but at least for simple arguments we should store by value.

Corrects bug #1361.

The original powerlaw integration functions were prone to overflows for large gammas as the function computed the pow(energy, -gamma), where -gamma can be a large positive number.

…servation definition XML files

This avoids entering oscillations in case of bad convergence behaviour.

The XML module now handles predefined entities. Special characters, such as " will now be transformed into their predefined entities, e.g. ", when writing the XML file. Upon reading, predefined entities will be converted into special chacaters, so that the user always deals with a human readable string.

A new parameter was introduce to specify the acceptable function decrease in an iteration. Acceptable means that the new parameters are kept for continuing the iterations. This behaviour existed already before, but a low threshold of 1e-6 did not really activate it. Now the threshold was raised to 1.0 and this help ctlike to converge quicker. Methods accept_dec() have been implemented to get and set the acceptable threshold.

This improves convergence, but there is not real justification for that except that it will likely improve the precision of the computations.

Linear delta binning accelerates the interpolation scheme.

Not sure why this was set to 0.1.

…try while the response computation is done in spherical trigonometry.

…ped from optimization method.

Conflicts:
	ChangeLog
	inst/cta/src/GCTAResponse_helpers.cpp
	inst/cta/src/GCTASupport.hpp

… radians; this led to convergence problems with the shell model).

Only the model-based integrations allow a proper and easy handling of the elliptical models.

This appears more natural for an ellipse.

…strange Npred profile.

The binned analysis looks okay, but unbinned shows a strange behaviour for the semiminor axis parameter which results in a strong dependency of Npred on the semiminor axis value. This seems to prevent a nice convergence in unbinned mode.

There is also an open issue to be solved related to the possibility that the minor axis is larger than the major axis. The actual code assumes that minor axis < major axis. If this is not fulfilled, the omega arc computations will be wrong.