Commit 374f8bf67c562efe3281945e6f20e731508c7c38
1 parent
b7116e08
Complete Git workflow documentation
Showing
1 changed file
with
24 additions
and
0 deletions
doc/source/develop/git/index.rst
| ... | ... | @@ -216,3 +216,27 @@ that a new branch exists in your project: |
| 216 | 216 | :alt: Pushing a new branch |
| 217 | 217 | :align: center |
| 218 | 218 | |
| 219 | + | |
| 220 | +Creating a pull request | |
| 221 | +----------------------- | |
| 222 | + | |
| 223 | +Once the code is pushed into your repository you can create a request that | |
| 224 | +your code should be merged into the GammaLib repository. | |
| 225 | +For this you have to open the relevant issue in the | |
| 226 | +`Redmine issue tracker <https://cta-redmine.irap.omp.eu/projects/gammalib/issues>`_ | |
| 227 | +and put the status of the issue to ``Pull request``: | |
| 228 | + | |
| 229 | +.. image:: pull-request.jpg | |
| 230 | + :width: 600px | |
| 231 | + :alt: Creating a pull request | |
| 232 | + :align: center | |
| 233 | + | |
| 234 | +You should indiciate in the notes in which repository and on which branch | |
| 235 | +your change is. | |
| 236 | +You should also describe the changes or addition you made to the code. | |
| 237 | +Explain what you have done. Say if there is anything you’d like particular | |
| 238 | +attention for - like a complicated change or some code you are not happy | |
| 239 | +with. | |
| 240 | +If you don’t think your request is ready to be merged, just say so in your | |
| 241 | +pull request message. | |
| 242 | +This is still a good way of getting some preliminary code review. | ... | ... |