Olga Sergijenko / gammalib

Commit ca0d79f476b44f60e33ed5fc5d9720b882ce53ca

Authored by Jürgen Knödlseder
1 parent e0888fb7

Correct copy base class in copy constructors (#3402) 

A major bug was lurking in the GModelSpatialDiffuse, GModelSpatialElliptical and GModelSpatialRadial classes where the GModelSpatial base class members were not copied in the copy constructors. This prevented in particular the model fitting of diffuse maps in the stacked analysis.
Inline Side-by-side
Showing 3 changed files with 3 additions and 3 deletions
src/model/GModelSpatialDiffuse.cpp
  View file @ca0d79f
@@ -65,7 +65,7 @@ GModelSpatialDiffuse::GModelSpatialDiffuse(void) : GModelSpatial() @@ -65,7 +65,7 @@ GModelSpatialDiffuse::GModelSpatialDiffuse(void) : GModelSpatial()
65 * @param[in] model Diffuse spatial model. 65 * @param[in] model Diffuse spatial model.
66 ***************************************************************************/ 66 ***************************************************************************/
67 GModelSpatialDiffuse::GModelSpatialDiffuse(const GModelSpatialDiffuse& model) : 67 GModelSpatialDiffuse::GModelSpatialDiffuse(const GModelSpatialDiffuse& model) :
68 - GModelSpatial() 68 + GModelSpatial(model)
69 { 69 {
70 // Initialise members 70 // Initialise members
71 init_members(); 71 init_members();
src/model/GModelSpatialElliptical.cpp
  View file @ca0d79f
@@ -89,7 +89,7 @@ GModelSpatialElliptical::GModelSpatialElliptical(const GXmlElement& xml) : @@ -89,7 +89,7 @@ GModelSpatialElliptical::GModelSpatialElliptical(const GXmlElement& xml) :
89 * @param[in] model Elliptical spatial model. 89 * @param[in] model Elliptical spatial model.
90 ***************************************************************************/ 90 ***************************************************************************/
91 GModelSpatialElliptical::GModelSpatialElliptical(const GModelSpatialElliptical& model) : 91 GModelSpatialElliptical::GModelSpatialElliptical(const GModelSpatialElliptical& model) :
92 - GModelSpatial() 92 + GModelSpatial(model)
93 { 93 {
94 // Initialise members 94 // Initialise members
95 init_members(); 95 init_members();
src/model/GModelSpatialRadial.cpp
  View file @ca0d79f
@@ -90,7 +90,7 @@ GModelSpatialRadial::GModelSpatialRadial(const GXmlElement& xml) : @@ -90,7 +90,7 @@ GModelSpatialRadial::GModelSpatialRadial(const GXmlElement& xml) :
90 * @param[in] model Radial spatial model. 90 * @param[in] model Radial spatial model.
91 ***************************************************************************/ 91 ***************************************************************************/
92 GModelSpatialRadial::GModelSpatialRadial(const GModelSpatialRadial& model) : 92 GModelSpatialRadial::GModelSpatialRadial(const GModelSpatialRadial& model) :
93 - GModelSpatial() 93 + GModelSpatial(model)
94 { 94 {
95 // Initialise members 95 // Initialise members
96 init_members(); 96 init_members();