Olga Sergijenko / gammalib

The GModelSpatial::region() method returns a pointer to a sky region that fully encloses the spatial model component.

…ients argument (#1847)

The eval_gradients() methods duplicate much of the code of the eval() methods. To increase the maintainability of the code, the eval_gradients() methods have been removed, and the computation of partial derivatives is now done by the eval() methods if the optional gradients argument is set to true.

…for Monte Carlo simulations.

Remove the Monte Carlo cash computation from GModelSpatialDiffuseMap::prepare_map() method.

Rename GModelSpatialDiffuseMap::norm() method to  GModelSpatialDiffuseMap::mc_norm() and call GModelSpatialDiffuseMap::set_mc_cone() in that method.

The norm() method has been added to the abstract GModelSpatial interface that returns the model normalization within a circular region. This is used in the GModelSky::mc method to correctly reflect the normalization specified in the XML file. The method is also used to flag sources outside the simulation cone (applies so for the point sources, radial source and elliptical sources).

The normalize attribute provides control over whether a map should be normalize or not. By default a map will be normalize to that the spectral model provides the correct fluxes, but for some specific analyses, normalization can now be switched off by adding normalize="0" in the XML file. The attribute has also be added as optional argument to the constructors. A unit test has been added that checks the functionnality.

The eval() and eval_gradients() methods now take a GPhoton object as argument to allow the implementation of energy and time dependent source morphologies.

GEnergy and GTime objects have been added to the mc() method interface to support equally the implementation of energy and time dependent source morphologies.

So far, no class really implements energy and time dependent source morphologies, but now we have the infrastructure to do so.

All diffuse spatial models are now derived from GModelSpatialDiffuse and named GModelSpatialDiffuseXXX.