Olga Sergijenko / gammalib

A major bug was lurking in the GModelSpatialDiffuse, GModelSpatialElliptical and GModelSpatialRadial classes where the GModelSpatial base class members were not copied in the copy constructors. This prevented in particular the model fitting of diffuse maps in the stacked analysis.

…ients argument (#1847)

The eval_gradients() methods duplicate much of the code of the eval() methods. To increase the maintainability of the code, the eval_gradients() methods have been removed, and the computation of partial derivatives is now done by the eval() methods if the optional gradients argument is set to true.

This appears more natural for an ellipse.

Any elliptical model should be defined by semiminor and semimajor axes, these are in fact used in the CTA response computation. Hence they should live in the baseclass, not the derived class.

The coding and design conventions (CDC) document was also updated.

The eval() and eval_gradients() methods now take a GPhoton object as argument to allow the implementation of energy and time dependent source morphologies.

GEnergy and GTime objects have been added to the mc() method interface to support equally the implementation of energy and time dependent source morphologies.

So far, no class really implements energy and time dependent source morphologies, but now we have the infrastructure to do so.

The GModelPar interface has been revisited and the code has been adapted to satisfy the new interface.