-
The binned analysis looks okay, but unbinned shows a strange behaviour for the semiminor axis parameter which results in a strong dependency of Npred on the semiminor axis value. This seems to prevent a nice convergence in unbinned mode. There is also an open issue to be solved related to the possibility that the minor axis is larger than the major axis. The actual code assumes that minor axis < major axis. If this is not fulfilled, the omega arc computations will be wrong.
-
Any elliptical model should be defined by semiminor and semimajor axes, these are in fact used in the CTA response computation. Hence they should live in the baseclass, not the derived class.
-
The coding and design conventions (CDC) document was also updated.
-
Add GChatter argument to print() method. The print() method now takes an argument of type GChatter to control the chattiness of the output in a homogenous manner. Pass NORMAL chatter level in __str__ method. Add chatter argument to print() methods. Use GLog::chatter() method to control the chattiness of the log stream operator. Add chatter() methods and provide member access through const references. Add chatter() methods, provide member access through const references, and declare one liners as inline methods. The chatter() methods control the new m_chatter attribute that is used to control the chattiness of the object's print() methods. name() and version() methods return const references. logFileOpen() method now sets the chattiness from the applications's chatter parameter, and name() and version() methods now return a const reference.
-
The eval() and eval_gradients() methods now take a GPhoton object as argument to allow the implementation of energy and time dependent source morphologies. GEnergy and GTime objects have been added to the mc() method interface to support equally the implementation of energy and time dependent source morphologies. So far, no class really implements energy and time dependent source morphologies, but now we have the infrastructure to do so.
-
The GModelPar interface has been revisited and the code has been adapted to satisfy the new interface.
-
The minor() and major() methods produced problems on FreeBSD where both functions are predefined macros.
-
I quickly went over the code before integration to make it compliant to the coding standards. Most of the modifications were cosmetical (related to code formating) In GModelSpatialEllipticalDisk::eval() I removed the std::pow(..., 2) calls and replaced them by simple multiplications as the later are much faster. This should speed up the computation somewhat. More importantly, I added an initial check on theta to see whether the position is located within the enclosing circle of the ellipse. This will simply return 0 for any locations outside the circle, avoiding unnecessary computations. In GModelSpatialEllipticalDisk::theta_max(), I added a check on whether major() or minor() are the larger value, and based on the check, I return the larger of both. This is important as a model fit may make minor() larger than major(). In GModelSpatialEllipticalDisk::read() and GModelSpatialEllipticalDisk::write(), a few bugs have been corrected.
