-
It seems more logical to start with the calibration database and then specify the response name in that calibration database.
-
… methods from GTools.
-
… simplify the code for reading and writing of XML files.
-
Adapt the code to the usage of GCaldb for response access.
-
Now, GCaldb only reads the CALDB environment variable when needed. This allows changing the CALDB environment variable during runtime. Rename GCaldb::dir to GCaldb::rootdir.
-
The coding and design conventions (CDC) document was also updated.
-
The old scheme with the deadtime correction in the base class led to some irf/npred methods having deadtime correction and others without correction. This definitely was a source of confusion and potential errors. Now, deadtime corrections have to be done at the instrument level, enhancing clarity of the interfaces and flexibility, at the expense of some burden on the instrument specific response class implementation that now has to take care of the proper handling of deadtime.
-
The previous scheme had some risk of running out of the response array.
-
Add GChatter argument to print() method. The print() method now takes an argument of type GChatter to control the chattiness of the output in a homogenous manner. Pass NORMAL chatter level in __str__ method. Add chatter argument to print() methods. Use GLog::chatter() method to control the chattiness of the log stream operator. Add chatter() methods and provide member access through const references. Add chatter() methods, provide member access through const references, and declare one liners as inline methods. The chatter() methods control the new m_chatter attribute that is used to control the chattiness of the object's print() methods. name() and version() methods return const references. logFileOpen() method now sets the chattiness from the applications's chatter parameter, and name() and version() methods now return a const reference.
-
Instead of using the observed and true attributes of the event and photon as arguments, the event and photon is now passed directly.
-
The IAQ file gives probabilities per Phigeo bin. To directly use the IAQ for the response calculation, the IAQ values are renormalized so that they are given per steradian. The code has been inspired from the original COMPTEL code (diffit routine setiaq.f). The irf() method was implement to obtained the point spread response function. The method has been inspired from the diffit routine iaqval.f. So far, no speed optimization has been performed. The primary goal of this commit was to get the functionnality.
-
This initial version of the COMPTEL response class implements the loading of the IRF values and IRF definition from the FITS file. The IRF access is not yet implemented.