Sergio Hernández Cadena / gammalib

The coding and design conventions (CDC) document was also updated.

…omatically detected King profile PSF upon IRF loading.

A unit test was added to verify that the King profile PSF is normalized correctly. For this purpose a King profile PSF calibration was inserted in slot 2 (bcf/000002) of the calibration database.

As the delta_max has been fixed to 0.7 degrees, the King profile PSF now returns 0 for delta angles larger than 0.7 deg. Furthermore, the PSF is normalized so that the integral from 0 to 0.7 deg gives 1. In that way we assure that the PSF integral is always 1.

The GCTAResponse::load_psf method now automatically detected the King profile PSF. Also, the load method now allow specification of a FITS file as the IRF name.

…hods to reduce duplicate code.

Using forward declarations instead of includes reduces the file dependencies. We should revise the code globally to use only includes whene really needed.

The GCTAResponse::retrieve methods provide type casting so that the relevant references are extracted from the generic pointers.

The abstract pointing class has been removed as so far no abstract pointing interface is needed.

The GFits class now derives from GContainer and implements all generic container class methods (at(), size(), isempty(), set(), append(), insert(), remove(), reserve(), extend()). The hashdu() method has been renamed to contains() for compliance with other container classes. The hdu() methods have been renamed to at(), also for compliance. Boolean arguments are now passed as const references, and members are returned as const references. HDU access operators[] have been implemented to access FITS extensions without range checking.

The GCTADir class is not used anymore in the CTA interface, hence it has been removed.

A contains() method has been added to GCTARoi that checks whether an event in contained within the ROI. This method will become pure virtual in the GRoi class later so that the check can be done independently of the ROI specifications.

The contains() method is now used in GCTAModelBackground for checking whether an event lies within the ROI.

The GCTAInstDir class now only has the dir() method to access and modify the GSkyDir member. All methods that were basically copied from GSkyDir have now been removed to avoid code duplication. Using the dir() method, all methods are now directly accessible from the GSkyDir object.

The old scheme with the deadtime correction in the base class led to some irf/npred methods having deadtime correction and others without correction. This definitely was a source of confusion and potential errors. Now, deadtime corrections have to be done at the instrument level, enhancing clarity of the interfaces and flexibility, at the expense of some burden on the instrument specific response class implementation that now has to take care of the proper handling of deadtime.

…ing IRF information so that the thetacut is applied correctly to effective areas provided in the ARF format.

The thetacut application has been removed after response factorization, leading to fit results that differ substantially from the results found for 1DC analysis using gammalib-00-05-00. Now, using the apply_thetacut() method essentially the same results are found.

Add GChatter argument to print() method.

The print() method now takes an argument of type GChatter to control the chattiness of the output in a homogenous manner.
Pass NORMAL chatter level in __str__ method.
Add chatter argument to print() methods.
Use GLog::chatter() method to control the chattiness of the log stream operator.
Add chatter() methods and provide member access through const references.
Add chatter() methods, provide member access through const references, and declare one liners as inline methods.

The chatter() methods control the new m_chatter attribute that is used to control the chattiness of the object's print() methods.
name() and version() methods return const references.
logFileOpen() method now sets the chattiness from the applications's chatter parameter, and name() and version() methods now return a const reference.

Using a pre computation caches considerably speeds up the computation for diffuse models.

All arguments for class constructions are now passed by reference.

The documentation, and in particular the formulae, have been updated.

The irf_elliptical method compute the IRF for elliptical models.

So far only the abstract base class has been introduced as no interface is yet defined. Once the interface is defined, a derived class should be implemented to read the energy dispersion information from disk.

The effective area and the point spread function are now implemented using derived classes of GCTAAeff and GCTAPsf. These base classes implement the interface for abstract effective area and point spread function. Various response function versions are then implemented to support the different response formats. The interface has been reviewed to take into account the new response definition.