• The code has been reviewed following integration. The code has be reformatted to fit the gammalib coding conventions.
    
    In GCTAInstDir, the detx() and dety() methods have been declared inline in the header file.
    
    For GCTAModelBackground, the code has been modified to work also properly when the number of energy bins is specified in the constructor. The default arguments for number of sky pixels and energy bins has been set to 0, as this is sufficient for the internal check (the -999 is somehow arbitrary, 0 seems to be more "well defined").
    
    In GCTAPointing, the instdir() and skydir() methods do no longer return references. Returning references was not okay here as the objects were allocated locally within the methods, and the objects run out of scope when leaving the methods. The references are thus no longer valid.
    
    In GCTAResponseTable, the new index and weight members have been added to init_members() and copy_members(). Furthermore, methods have been added that allow to retrieve the axis and parameter units.
    Jürgen Knödlseder authored
     
    Browse File »




  • A major revision of the GFitsTable class interface has been done, making it more similar to the interface of other container classes. In particular, the column access operator now returns a pointer instead of a reference, preventing code slicing. The set() method has been introduced to set columns in a table. The append_column() and insert_column() methods have been renamed to append() and insert() as they act on columns, and a table is a column container. Some arguments or return values are now also declared as const references. A size() method has been added that return the number of table columns.
    
    As the GFitsTable class is widely used throughout GammaLib, a number of classes had to be adapted to this new interface.
    Jürgen Knödlseder authored
     
    Browse File »


  • Add GChatter argument to print() method.
    
    The print() method now takes an argument of type GChatter to control the chattiness of the output in a homogenous manner.
    Pass NORMAL chatter level in __str__ method.
    Add chatter argument to print() methods.
    Use GLog::chatter() method to control the chattiness of the log stream operator.
    Add chatter() methods and provide member access through const references.
    Add chatter() methods, provide member access through const references, and declare one liners as inline methods.
    
    The chatter() methods control the new m_chatter attribute that is used to control the chattiness of the object's print() methods.
    name() and version() methods return const references.
    logFileOpen() method now sets the chattiness from the applications's chatter parameter, and name() and version() methods now return a const reference.
    Jürgen Knödlseder authored
     
    Browse File »

  • The size() method was used as if it gave the response table dimension. A new method axes() has been introduced that gives the response table dimension, and size() is now coherently used for the number of parameters in the response table.
    Jürgen Knödlseder authored
     
    Browse File »

  • As m_npars is used in the size() method, and the size() method is used in other reading methods, m_npars has to be as early as possible. We thus set m_npars at the end of the read_colnames() method, where the number of parameters is determined for the first time.
    Jürgen Knödlseder authored
     
    Browse File »

  • Previously, interpolation operators always returned a vector of response parameters. This wasted ressources in cases where only a single parameter was required. Additional operators have been added that allow interpolation of individual response parameters.
    
    A scale() method has been added that allows scaling (multiplication) of parameter values by a given factor. This reduces computations in parameter access by one additional multiplication in case that the parameter value needs to be scaled.
    Jürgen Knödlseder authored
     
    Browse File »