Thierry Louge / gammalib

…ients argument (#1847)

The eval_gradients() methods duplicate much of the code of the eval() methods. To increase the maintainability of the code, the eval_gradients() methods have been removed, and the computation of partial derivatives is now done by the eval() methods if the optional gradients argument is set to true.

If an application is constructed from the command line arguments with the --help option the application parameters are not loaded, and the destructor saved before the empty parameter container to disk, which effectively emptied the parameter file. Now the desctructor only save the parameters if they have been loaded before.

The result of the log-likelihood computation was lost in a copy of the GObservations class. Now it is conserved.

The application name and version were cleared in a call of the GApplication::clear() method, but these properties should be conserved. Now they are, and a call of the GApplication::clear()  will perform the same actions than a call of the name and version constructor.

The optional linefeed parameter allows to terminate the string with (default) or without a linefeed.

The GApplication::log_parameters() method now takes a mandatory GChatter argument to enable displaying of parameters only above a given chattiness level. This avoids a log-level check in the client code. For the same purpose, the GApplication methods log_string(), log_value(), log_header1(), log_header2(), and log_header3() have been introduced (#1828).

… including docs and unit tests

  - New naming scheme.
  - New utility functions/constructor supporting cutoff-energy.
  - Usage of new helper functions for xml read-in/write-out.

The GModelSpectralRegistry::alloc() method now also checks for the existence of model parameters and allocates the appropriate model from the registry that is found in the XML file base on model type and parameter names. This allows now to have the same model type but different parameter names in the registry.

The spectral model classes have been adapted to the new logic, and models have been added to the registry for all parameter combinations that may exist.

The unit tests and documentation have been updated.

Remove the m_names members from the spatial, spectral and temporal registry classes and directly use the model type to find the appropriate model. The alloc() method now throws an exception if the model is not found. The new logic helped to reduced the code in the client classes (#1824)

This is in anticipate of the model name changes in release 1.2

This is an anticipation of the renaming of the spectral models that will come in release 1.2.

It seems better to not introduce the alias method but to use a type constructor instead. This allows writing out the same model type that was read in, enhancing the compatibility with the legacy XML format.