Add self.logFileOpen() to cstsmapsplit.execute() method (#2127)

Jürgen Knödlseder
1 parent 122cca1a
Showing 16 changed files with 99 additions and 35 deletions
ChangeLog
NEWS
cscripts/cscaldb.py
cscripts/csebins.py
cscripts/csiactcopy.py
cscripts/csiactdata.py
cscripts/csobs2caldb.py
cscripts/cspull.py
cscripts/csroot2caldb.py
cscripts/cssens.py
cscripts/cstsdist.py
cscripts/cstsmapsplit.py
cscripts/csviscube.py
cscripts/csworkflow.py
doc/source/admin/release_history/1.3.1.rst
doc/source/admin/release_history/index.rst
-2017-06-30
+2017-07-03
         * Bug fix version 1.3.1 released
         ================================
@@ -6,6 +6,7 @@
         Fix csresmap significance computation error (#2136)
         Use MigMatrixNoTheta2cut_offaxis and AngularPSF2DEtrue_offaxis histograms to
           compute PSF and energy dispersion IRFs (#2135)
+        Add self.logFileOpen() to cstsmapsplit.execute() method (#2127)
         Properly forward working log file pointer in ctobssim::set_mc_id_names() (#2123)
         Correct computation of standard deviations in cssrcdetect
         csobsselect accepts an observation container upon construction
 New Features and Important Changes in ctools 1.3.1
-29 June 2017
+3 July 2017
 Introduction
@@ -130,6 +130,9 @@ The csresmap threw an exception for the SIGNIFICANCE method when the model map
 contained zero entries. This has been fixed now by properly handling the case of
 zero entries (#2136).
+A call to self.logFileOpen() has been added to the cstsmapsplit.execute() method
+so that a log file is written when the script is executed (#2127).
+
 Examples
 --------
@@ -204,6 +204,9 @@ class cscaldb(ctools.cscript):
         # Open logfile
         self.logFileOpen()
+        # Read ahead output parameters
+        self._read_ahead(True)
+
         # Run the script
         self.run()
@@ -272,25 +272,6 @@ class csebins(ctools.cscript):
         # Return
         return
-    def execute(self):
-        """
-        Execute the script
-        """
-        # Open logfile
-        self.logFileOpen()
-
-        # Read ahead output parameters
-        self._read_ahead(True)
-
-        # Run the scrip
-        self.run()
-
-        # Save energy boundaries
-        self.save()
-
-        # Return
-        return
-
     def save(self):
         """
         Save energy boundaries
@@ -322,6 +303,25 @@ class csebins(ctools.cscript):
         # Return
         return self._ebounds
+    def execute(self):
+        """
+        Execute the script
+        """
+        # Open logfile
+        self.logFileOpen()
+
+        # Read ahead output parameters
+        self._read_ahead(True)
+
+        # Run the scrip
+        self.run()
+
+        # Save energy boundaries
+        self.save()
+
+        # Return
+        return
+
 # ======================== #
 # Main routine entry point #
@@ -743,6 +743,9 @@ class csiactcopy(ctools.cscript):
         # Open logfile
         self.logFileOpen()
+        # Read ahead output parameters
+        self._read_ahead(True)
+
         # Run the script
         self.run()
@@ -184,6 +184,9 @@ class csiactdata(ctools.cscript):
         # Open logfile
         self.logFileOpen()
+        # Read ahead output parameters
+        self._read_ahead(True)
+
         # Run the script
         self.run()
@@ -400,6 +400,9 @@ class csobs2caldb(ctools.cscript):
         # Open logfile
         self.logFileOpen()
+        # Read ahead output parameters
+        self._read_ahead(True)
+
         # Run the script
         self.run()
@@ -329,6 +329,9 @@ class cspull(ctools.cscript):
         # Open logfile
         self.logFileOpen()
+        # Read ahead output parameters
+        self._read_ahead(True)
+
         # Run the script
         self.run()
@@ -1784,6 +1784,9 @@ class csroot2caldb(ctools.cscript):
         # Open logfile
         self.logFileOpen()
+        # Read ahead output parameters
+        self._read_ahead(True)
+
         # Run the script
         self.run()
@@ -649,6 +649,9 @@ class cssens(ctools.cscript):
         # Open logfile
         self.logFileOpen()
+        # Read ahead output parameters
+        self._read_ahead(True)
+
         # Run the script
         self.run()
@@ -295,6 +295,9 @@ class cstsdist(ctools.cscript):
         # Open logfile
         self.logFileOpen()
+        # Read ahead output parameters
+        self._read_ahead(True)
+
         # Run the script
         self.run()
@@ -255,19 +255,6 @@ class cstsmapsplit(ctools.cscript):
         # Return
         return
-    def execute(self):
-        """
-        Execute the script
-        """
-        # Run the script
-        self.run()
-        
-        # Save results
-        self.save()
-        
-        # Return
-        return
-
     def save(self):
         """
         Save commands to ASCII file
@@ -291,6 +278,25 @@ class cstsmapsplit(ctools.cscript):
         # Return
         return
+    def execute(self):
+        """
+        Execute the script
+        """
+        # Open logfile
+        self.logFileOpen()
+
+        # Read ahead output parameters
+        self._read_ahead(True)
+
+        # Run the script
+        self.run()
+        
+        # Save results
+        self.save()
+        
+        # Return
+        return
+
 # ======================== #
 # Main routine entry point #
@@ -519,6 +519,9 @@ class csviscube(ctools.cscript):
         # Open logfile
         self.logFileOpen()
+        # Read ahead output parameters
+        self._read_ahead(True)
+
         # Run the script
         self.run()
@@ -360,6 +360,9 @@ class csworkflow(ctools.cscript):
         # Open logfile
         self.logFileOpen()
+        # Read ahead output parameters
+        self._read_ahead(True)
+
         # Run the script
         self.run()
+.. _1.3.1:
+
+ctools 1.3.1 release (TBD)
+==========================
+
+Overview
+--------
+
+ctools 1.3.1 is a bug fix for ctools release 1.3.
+
+The following bugs have been fixed:
+
+* [`2136 <https://cta-redmine.irap.omp.eu/issues/2136>`_] -
+  Fix csresmap significance computation error
+* [`2135 <https://cta-redmine.irap.omp.eu/issues/2135>`_] -
+  Use ``MigMatrixNoTheta2cut_offaxis`` and ``AngularPSF2DEtrue_offaxis``
+  histograms to compute PSF and energy dispersion IRFs
+* [`2127 <https://cta-redmine.irap.omp.eu/issues/2127>`_] -
+  Add ``self.logFileOpen()`` to ``cstsmapsplit.execute()`` method
+* [`2123 <https://cta-redmine.irap.omp.eu/issues/2123>`_] -
+  Properly forward working log file pointer in ``ctobssim::set_mc_id_names()``
+* Correct computation of standard deviations in :ref:`cssrcdetect`
+* :ref:`csobsselect` accepts an observation container upon construction
@@ -18,8 +18,9 @@ Bug fix releases:
 .. toctree::
    :maxdepth: 1
-   ctools 1.0.1 <1.0.1>
+   ctools 1.3.1 <1.3.1>
    ctools 1.2.1 <1.2.1>
+   ctools 1.0.1 <1.0.1>
 For older ctools versions see
 `here <https://cta-redmine.irap.omp.eu/projects/ctools/wiki/Release_notes>`_.