Johan Bregeon / gammalib

…ll GModelData derivatives

…name then filename is extracted from the parameter file. Thus any parameter update is correctly propagated. This fixes a bug where the logfile change was not taken into account under Python.

Dates were appended in the middle of a text block if the buffer was flushed before a \n character was reached. A private member m_linestart has been added that tracks whether the buffer is actually at a line start or the middle of a text block. Dates are only set at the beginning of the buffer is the buffer is at a line start.

The code has been reformated after changing the class names from GPar to GApplicationPar and GPars to GApplicationPars. The renaming has been logged in the ChangeLog file.

(I chose `centre` because there were more `centre` than `center`
around.)

The coding and design conventions (CDC) document was also updated.

The GFits class now derives from GContainer and implements all generic container class methods (at(), size(), isempty(), set(), append(), insert(), remove(), reserve(), extend()). The hashdu() method has been renamed to contains() for compliance with other container classes. The hdu() methods have been renamed to at(), also for compliance. Boolean arguments are now passed as const references, and members are returned as const references. HDU access operators[] have been implemented to access FITS extensions without range checking.

Log file creation may now be disabled by specifying logfile= on the command line. The GPars class has to be changed for this to support empty value arguments.

String members are now returns as const references.

The GPars class now derives from GContainer and implements all standard container class methods. GApplication now allows specifying a log filename using the logfile parameter in the parameter file.

Add GChatter argument to print() method.

The print() method now takes an argument of type GChatter to control the chattiness of the output in a homogenous manner.
Pass NORMAL chatter level in __str__ method.
Add chatter argument to print() methods.
Use GLog::chatter() method to control the chattiness of the log stream operator.
Add chatter() methods and provide member access through const references.
Add chatter() methods, provide member access through const references, and declare one liners as inline methods.

The chatter() methods control the new m_chatter attribute that is used to control the chattiness of the object's print() methods.
name() and version() methods return const references.
logFileOpen() method now sets the chattiness from the applications's chatter parameter, and name() and version() methods now return a const reference.

The file was corrected so that no more warnings occur during Doxygen documentation generation.

Since we have to query the parameter to determine it's status, the isvalid(), isundefined() and isnotanumber() methods now call query(). This implies that the methods had to be passed non-const, as query() modifies the members of the parameter.

The parameter validity is checked before returning a value. This ensures that invalid values are not inadvertedly passed to the executable. The isvalid() method can be used to ensure that a parameter is valid before accessing it.

It is recommended to pass all arguments to exceptions by reference to avoid memory allocation during exception throwing.

The #include <climits> statement was placed within the conditional HAVE_LIBREADLINE block, so that the file was not included if readline was not available. This has been fixed now.

Determines the parameter status in the set_value() method.

The special values INDEF, NONE, UNDEF and UNDEFINED (case insensitive) can now be passed to integer and floating point parameters, leading to a status of "undefined". This status can be checked using the isundefined() method.

The spacial values INF, INFINITY or NAN (case insensitive) can now be passed to integer and floating point parameters. For integer parameter, the maximum long number will be assigned. For floating point parameter, the status will be changed to "not a number". This status can be checked using the isnotanumber() method.

All other values will lead to a valid status, which can be checked using the isvalid() method.

Following the APE interface, the following boolean values are now allowed (case insensitive): y,yes,true,t or n,no,false,f.

Task #634.

All classes our now derived from GBase. For this we had to define and to implement the clear() method for all classes. ostream and GLog friends have also been removed, as they are no implemented at the GBase level.

The ostream and GLog functions are now implement on the GBase level.

Not all filesystems support file locking. Previously, an exception has been thrown in case that parfile locking failed. Now, no exception is thrown anymore, and the parfile is read or written without locking in case that file locking is not possible.

The parfile locking check is controlled by the compile option G_CHECK_LOCK_PARFILE. If undefined, no checking will be performed. If defined, checking will be performed.

The change has been performed to try avoiding a cppcheck error. The code was also reviewed for compliance.

The code was overseen to comply to the GammaLib coding standards.

The m_newline member has been removed as this member is not used any longer.

The m_filename member is now initialized correctly in init_members() and copied in copy_members().

A new method named prefix() has been added that provides the prefix. This reduces code duplication in the append() method. Furthermore, a possible indent was put back that was removed during code revision.

Prefixes are now added in the append method.

An attempt to remove the cppcheck error.

We use append to set the string value instead of the assignment operator to make Cppcheck happy. Cppcheck claimed that we return an auto variable, which a priori was not the case.

A possible ressource leak of fptr was signalled by cppcheck.