Justine Devin / gammalib

…ts for GEbounds::contains() methods.

set_mc_cone() called fetch_cube() which itself called load() which itself called set_mc_cone() with a larger cone again. This led to a neverending recursion.

I now introduced a load_cube() method that does the proper loading and that does not call set_mc_cone() again. This method is now used in fetch_cube().

Before, always the first map has been accessed.

Before no parameter members have been copied as the loop used the actual size of the object instead of the size of the parameters to be copied.

…/s (conversion factor was missing).

The formula for drawing random numbers on a sphere was not correct. This has now been corrected, and verify using a dedicated test script (test_model_spatial_const.py).

…nvironment variable is not set.

This handles the special case that the PFILES environment variable is set, yet the parameter file does not exist. Before, in that case the users pfiles directory was searched for the parameter file. Now, if the parameter file is missing, it will be copied in from the syspfiles directory, which is the expected behaviour.

Switching to a fixed number of iterations led to an inaccuracy of the flux determination that affected considerably the pull distributions. In short, too many events have been simulated. I thus switched back to using the integration precision instead of using a fixed number of iterations, which should be okay for flux computation (flux computation is not involved in likelihood computations).

The check done in GSkymap::contains() was not correct, and pixel indices that were beyond the edge of the map by one pixel were still accepted. This lead in some cases to artefacts when using the GSkymap::operator() sky direction access operator. This is now corrected.

Having only 4 integration iterations leads to an exception as the default order for integration is 5. Hence the number of integration iterations was switched to 5 to prevent this problem.

Solves #1472.

Added a logger() method that allows setting the logger for an optimizer (and that also allows to set the NULL pointer)

The flux() method now computes an approximated flux value for HealPix projections. This flux estimate is accurate to 1-3% level, dependent on pixel and Nside parameter.

The following methods have been added:
- set_z_phi
- loc2dir
- xyf2loc
- pix2xyf
- max_pixrad
- boundaries
- neighbours

The wrap around in the X axis is now correctly dealt with in the interpolation operator.

Upon reading of the WCS map the size of the map is checked. Exceptions are thrown in case that the map is larger then 360 in X and larger than 180 in Y.

The flux() methods return the correct flux in a pixel considering that a bilinear interpolation is performed in the map. Flux is defined as intensity times solid angle.

This works so far only properly for WCS projections. For HealPix maps, only the pixel intensity times the solid angle is returned.