-
set_mc_cone() called fetch_cube() which itself called load() which itself called set_mc_cone() with a larger cone again. This led to a neverending recursion. I now introduced a load_cube() method that does the proper loading and that does not call set_mc_cone() again. This method is now used in fetch_cube().
-
…/s (conversion factor was missing).
-
The formula for drawing random numbers on a sphere was not correct. This has now been corrected, and verify using a dedicated test script (test_model_spatial_const.py).
-
Switching to a fixed number of iterations led to an inaccuracy of the flux determination that affected considerably the pull distributions. In short, too many events have been simulated. I thus switched back to using the integration precision instead of using a fixed number of iterations, which should be okay for flux computation (flux computation is not involved in likelihood computations).
-
…y intergation is done over all energy ranges in an energy boundary object (see #1450). Updated at the same time the Doxygen information.
-
…ion is done on an initial call. Before, the position angle computation was never executed for a position angle of zero. Discovered this by chance ...
-
The GModel::is_valid() method now allows specifying empty strings for the instrument and id parameters that will skip the specific model validity check. This allows to check for models of a given identifier whatever the instrument, or for models for a given instrument, whatever the identifier.
-
Not sure why this was set to 0.1.
-
Conflicts: ChangeLog inst/cta/src/GCTAResponse_helpers.cpp inst/cta/src/GCTASupport.hpp
-
This appears more natural for an ellipse.
-
The binned analysis looks okay, but unbinned shows a strange behaviour for the semiminor axis parameter which results in a strong dependency of Npred on the semiminor axis value. This seems to prevent a nice convergence in unbinned mode. There is also an open issue to be solved related to the possibility that the minor axis is larger than the major axis. The actual code assumes that minor axis < major axis. If this is not fulfilled, the omega arc computations will be wrong.